mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-04 17:06:16 +00:00
Code Issues Projects Releases Wiki Activity

Fixed infinite loop when placing two coral plants next to each other

Browse Source 
the dead flag is not persisted in their metadata, so they forget their state when next read from the world.
This commit is contained in:
Dylan K. Taylor
2021-04-19 23:01:57 +01:00
parent 4e0bc6c98e
commit fc01735b6f
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/block/Coral.php
View File

@ -30,6 +30,18 @@ use pocketmine\world\BlockTransaction;
final class Coral extends BaseCoral{
public function readStateFromWorld() : void{
//TODO: this hack ensures correct state of coral plants, because they don't retain their dead flag in metadata
$world = $this->pos->getWorld();
$this->dead = true;
foreach($this->pos->sides() as $vector3){
if($world->getBlock($vector3) instanceof Water){
$this->dead = false;
break;
}
}
}
public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
if(!$tx->fetchBlock($blockReplace->getPos()->down())->isSolid()){
return false;