From 9e1fa453adb92e247e1dd52ded871b460686ce95 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 6 Aug 2018 18:44:53 +0100 Subject: [PATCH] Level: Fixed leak of global packets when no players are online If a global packet was broadcasted when no players were online, it would be held in memory indefinitely (until a player joined). --- src/pocketmine/level/Level.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/level/Level.php b/src/pocketmine/level/Level.php index b63cb72d7..479614830 100644 --- a/src/pocketmine/level/Level.php +++ b/src/pocketmine/level/Level.php @@ -797,8 +797,10 @@ class Level implements ChunkManager, Metadatable{ $this->checkSleep(); } - if(!empty($this->players) and !empty($this->globalPackets)){ - $this->server->batchPackets($this->players, $this->globalPackets); + if(!empty($this->globalPackets)){ + if(!empty($this->players)){ + $this->server->batchPackets($this->players, $this->globalPackets); + } $this->globalPackets = []; }