mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-11 12:27:51 +00:00
Code Issues Projects Releases Wiki Activity

Entity: removed redundant return values for move()

Browse Source
This commit is contained in:
Dylan K. Taylor 2018-03-14 13:39:23 +00:00
parent ddc9dca8b4
commit fa644edef3
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pocketmine/entity/Entity.php
View File

@ -1512,13 +1512,9 @@ abstract class Entity extends Location implements Metadatable, EntityIds{
return true; return true;
} }
public function move(float $dx, float $dy, float $dz) : bool{ public function move(float $dx, float $dy, float $dz) : void{
$this->blocksAround = null; $this->blocksAround = null;
if($dx == 0 and $dz == 0 and $dy == 0){
return true;
}
Timings::$entityMoveTimer->startTiming(); Timings::$entityMoveTimer->startTiming();
$movX = $dx; $movX = $dx;
@ -1662,8 +1658,6 @@ abstract class Entity extends Location implements Metadatable, EntityIds{
//TODO: vehicle collision events (first we need to spawn them!) //TODO: vehicle collision events (first we need to spawn them!)
Timings::$entityMoveTimer->stopTiming(); Timings::$entityMoveTimer->stopTiming();
return true;
} }
protected function checkGroundState(float $movX, float $movY, float $movZ, float $dx, float $dy, float $dz){ protected function checkGroundState(float $movX, float $movY, float $movZ, float $dx, float $dy, float $dz){

4
src/pocketmine/entity/projectile/Projectile.php
View File

@ -153,7 +153,7 @@ abstract class Projectile extends Entity{
return $parent; return $parent;
} }
public function move(float $dx, float $dy, float $dz) : bool{ public function move(float $dx, float $dy, float $dz) : void{
$this->blocksAround = null; $this->blocksAround = null;
Timings::$entityMoveTimer->startTiming(); Timings::$entityMoveTimer->startTiming();
@ -246,8 +246,6 @@ abstract class Projectile extends Entity{
Timings::$entityMoveTimer->stopTiming(); Timings::$entityMoveTimer->stopTiming();
return true;
} }
/** /**