mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-04 00:59:51 +00:00
Code Issues Projects Releases Wiki Activity

AsyncPoolTest: added failing test case for AsyncTask::__destruct() reentrancy bug

Browse Source
This commit is contained in:
Dylan K. Taylor 2023-07-01 13:24:50 +01:00
parent bbabccfc89
commit f8e6f036af
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
tests/phpunit/scheduler/AsyncPoolTest.php
View File

@ -69,4 +69,36 @@ class AsyncPoolTest extends TestCase{
} }
self::assertTrue(PublishProgressRaceAsyncTask::$success, "Progress was not reported before task completion"); self::assertTrue(PublishProgressRaceAsyncTask::$success, "Progress was not reported before task completion");
} }
/**
* This test ensures that the fix for an exotic AsyncTask::__destruct() reentrancy bug has not regressed.
*
* Due to an unset() in the function body, other AsyncTask::__destruct() calls could be triggered during
* an AsyncTask's destruction. If done in the wrong way, this could lead to a crash.
*
* @doesNotPerformAssertions This test is checking for a crash condition, not a specific output.
*/
public function testTaskDestructorReentrancy() : void{
$this->pool->submitTask(new class extends AsyncTask{
public function __construct(){
$this->storeLocal("task", new class extends AsyncTask{
public function __construct(){
$this->storeLocal("dummy", 1);
}
public function onRun() : void{
//dummy
}
});
}
public function onRun() : void{
//dummy
}
});
while($this->pool->collectTasks()){
usleep(50 * 1000);
}
}
} }