mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 20:28:31 +00:00
Code Issues Projects Releases Wiki Activity

Cache a compressed CraftingDataPacket to reduce workload on player join

Browse Source 
this saves only a couple of ms per player join, but still worth it.
This commit is contained in:
Dylan K. Taylor 2017-10-29 09:57:55 +00:00
parent 6ce9e79cd5
commit f79e4237df
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pocketmine/inventory/CraftingManager.php
View File

@ -26,6 +26,7 @@ namespace pocketmine\inventory;
use pocketmine\event\Timings; use pocketmine\event\Timings;
use pocketmine\item\Item; use pocketmine\item\Item;
use pocketmine\item\ItemFactory; use pocketmine\item\ItemFactory;
use pocketmine\network\mcpe\protocol\BatchPacket;
use pocketmine\network\mcpe\protocol\CraftingDataPacket; use pocketmine\network\mcpe\protocol\CraftingDataPacket;
use pocketmine\Server; use pocketmine\Server;
use pocketmine\utils\Config; use pocketmine\utils\Config;
@ -47,7 +48,7 @@ class CraftingManager{
private static $RECIPE_COUNT = 0; private static $RECIPE_COUNT = 0;
/** @var CraftingDataPacket */ /** @var BatchPacket */
private $craftingDataCache; private $craftingDataCache;
public function __construct(){ public function __construct(){
@ -113,16 +114,21 @@ class CraftingManager{
$pk->encode(); $pk->encode();
$this->craftingDataCache = $pk; $batch = new BatchPacket();
$batch->addPacket($pk);
$batch->setCompressionLevel(Server::getInstance()->networkCompressionLevel);
$batch->encode();
$this->craftingDataCache = $batch;
Timings::$craftingDataCacheRebuildTimer->stopTiming(); Timings::$craftingDataCacheRebuildTimer->stopTiming();
} }
/** /**
* Returns a CraftingDataPacket for sending to players. Rebuilds the cache if it is outdated. * Returns a pre-compressed CraftingDataPacket for sending to players. Rebuilds the cache if it is not found.
* *
* @return CraftingDataPacket * @return BatchPacket
*/ */
public function getCraftingDataPacket() : CraftingDataPacket{ public function getCraftingDataPacket() : BatchPacket{
if($this->craftingDataCache === null){ if($this->craftingDataCache === null){
$this->buildCraftingDataCache(); $this->buildCraftingDataCache();
} }