mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

Remove hardcoded facing literals in for loops

Browse Source
This commit is contained in:
Dylan K. Taylor
2018-09-13 19:34:27 +01:00
parent 65684eec99
commit f488e594f6
9 changed files with 37 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/block/Lava.php
View File

@ -27,6 +27,7 @@ use pocketmine\entity\Entity;
use pocketmine\event\entity\EntityCombustByBlockEvent;
use pocketmine\event\entity\EntityDamageByBlockEvent;
use pocketmine\event\entity\EntityDamageEvent;
use pocketmine\math\Facing;
use pocketmine\network\mcpe\protocol\LevelSoundEventPacket;
use pocketmine\Server;
@ -72,7 +73,10 @@ class Lava extends Liquid{
protected function checkForHarden(){
$colliding = null;
for($side = 1; $side <= 5; ++$side){ //don't check downwards side
foreach(Facing::ALL as $side){
if($side === Facing::DOWN){
continue;
}
$blockSide = $this->getSide($side);
if($blockSide instanceof Water){
$colliding = $blockSide;