From f2e74736296eca93f3732cc64041535e824dab00 Mon Sep 17 00:00:00 2001
From: "Dylan K. Taylor" <dktapps@pmmp.io>
Date: Sun, 4 May 2025 17:18:58 +0100
Subject: [PATCH] Update PHP-CS-Fixer

---
 .github/workflows/main.yml   | 4 ++--
 .php-cs-fixer.php            | 6 ++++++
 build/dump-version-info.php  | 4 ++--
 src/block/tile/Spawnable.php | 4 ++--
 src/world/World.php          | 2 +-
 5 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index cfe97aa7e..cabda54be 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -30,8 +30,8 @@ jobs:
       - name: Setup PHP and tools
         uses: shivammathur/setup-php@2.33.0
         with:
-          php-version: 8.2
-          tools: php-cs-fixer:3.49
+          php-version: 8.3
+          tools: php-cs-fixer:3.75
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
index 32af1ef48..5a14b1d35 100644
--- a/.php-cs-fixer.php
+++ b/.php-cs-fixer.php
@@ -6,6 +6,12 @@ $finder = PhpCsFixer\Finder::create()
 	->in(__DIR__ . '/tests')
 	->in(__DIR__ . '/tools')
 	->notPath('plugins/DevTools')
+	//JsonMapper will break if the FQNs in the doc comments for these are shortened :(
+	->notPath('crafting/json')
+	->notPath('inventory/json')
+	->notPath('data/bedrock/block/upgrade/model')
+	->notPath('data/bedrock/item/upgrade/model')
+
 	->notName('PocketMine.php');
 
 return (new PhpCsFixer\Config)
diff --git a/build/dump-version-info.php b/build/dump-version-info.php
index e13696f3d..3181acba6 100644
--- a/build/dump-version-info.php
+++ b/build/dump-version-info.php
@@ -31,8 +31,8 @@ require dirname(__DIR__) . '/vendor/autoload.php';
  */
 
 /**
- * @var string[]|\Closure[] $options
- * @phpstan-var array<string, string|\Closure() : string> $options
+ * @var string[]|Closure[] $options
+ * @phpstan-var array<string, string|Closure() : string> $options
  */
 $options = [
 	"base_version" => VersionInfo::BASE_VERSION,
diff --git a/src/block/tile/Spawnable.php b/src/block/tile/Spawnable.php
index 67bc72fd9..0c41713f2 100644
--- a/src/block/tile/Spawnable.php
+++ b/src/block/tile/Spawnable.php
@@ -32,7 +32,7 @@ use pocketmine\network\mcpe\protocol\types\CacheableNbt;
 use function get_class;
 
 abstract class Spawnable extends Tile{
-	/** @phpstan-var CacheableNbt<\pocketmine\nbt\tag\CompoundTag>|null */
+	/** @phpstan-var CacheableNbt<CompoundTag>|null */
 	private ?CacheableNbt $spawnCompoundCache = null;
 
 	/**
@@ -73,7 +73,7 @@ abstract class Spawnable extends Tile{
 	 * Returns encoded NBT (varint, little-endian) used to spawn this tile to clients. Uses cache where possible,
 	 * populates cache if it is null.
 	 *
-	 * @phpstan-return CacheableNbt<\pocketmine\nbt\tag\CompoundTag>
+	 * @phpstan-return CacheableNbt<CompoundTag>
 	 */
 	final public function getSerializedSpawnCompound() : CacheableNbt{
 		if($this->spawnCompoundCache === null){
diff --git a/src/world/World.php b/src/world/World.php
index 3a7d0c538..63a617126 100644
--- a/src/world/World.php
+++ b/src/world/World.php
@@ -360,7 +360,7 @@ class World implements ChunkManager{
 
 	private bool $doingTick = false;
 
-	/** @phpstan-var class-string<\pocketmine\world\generator\Generator> */
+	/** @phpstan-var class-string<generator\Generator> */
 	private string $generator;
 
 	private bool $unloaded = false;