mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-19 04:15:04 +00:00
Code Issues Projects Releases Wiki Activity

Removing "metadata": overengineered useless Bukkit copy-pasta

Browse Source 
the intentions of this are good, but the usability is terrible and it's not fit for purpose. Since there are a total of zero plugins on Poggit which use this garbage, it makes more sense to eliminate the technical debt. See #2766 for discussion about replacing this.
This commit is contained in:
Dylan K. Taylor
2019-06-26 14:43:21 +01:00
parent 26178b4435
commit ee72680f44
13 changed files with 4 additions and 601 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/pocketmine/world/World.php
View File

@@ -51,9 +51,6 @@ use pocketmine\item\ItemFactory;
use pocketmine\item\ItemUseResult;
use pocketmine\math\AxisAlignedBB;
use pocketmine\math\Vector3;
use pocketmine\metadata\BlockMetadataStore;
use pocketmine\metadata\Metadatable;
use pocketmine\metadata\MetadataValue;
use pocketmine\nbt\tag\ListTag;
use pocketmine\nbt\tag\StringTag;
use pocketmine\network\mcpe\protocol\BlockEntityDataPacket;
@@ -64,7 +61,6 @@ use pocketmine\network\mcpe\protocol\SetTimePacket;
use pocketmine\network\mcpe\protocol\types\RuntimeBlockMapping;
use pocketmine\network\mcpe\protocol\UpdateBlockPacket;
use pocketmine\player\Player;
use pocketmine\plugin\Plugin;
use pocketmine\Server;
use pocketmine\timings\Timings;
use pocketmine\utils\ReversePriorityQueue;
@@ -115,7 +111,7 @@ use const PHP_INT_MIN;
#include <rules/World.h>
class World implements ChunkManager, Metadatable{
class World implements ChunkManager{
private static $worldIdCounter = 1;
@@ -227,9 +223,6 @@ class World implements ChunkManager, Metadatable{
/** @var bool */
private $autoSave = true;
/** @var BlockMetadataStore */
private $blockMetadata;
/** @var Position */
private $temporalPosition;
/** @var Vector3 */
@@ -349,7 +342,6 @@ class World implements ChunkManager, Metadatable{
*/
public function __construct(Server $server, string $name, WritableWorldProvider $provider){
$this->worldId = static::$worldIdCounter++;
$this->blockMetadata = new BlockMetadataStore($this);
$this->server = $server;
$this->provider = $provider;
@@ -416,10 +408,6 @@ class World implements ChunkManager, Metadatable{
$this->generatorRegisteredWorkers = [];
}
public function getBlockMetadata() : BlockMetadataStore{
return $this->blockMetadata;
}
public function getServer() : Server{
return $this->server;
}
@@ -461,7 +449,6 @@ class World implements ChunkManager, Metadatable{
$this->provider->close();
$this->provider = null;
$this->blockMetadata = null;
$this->blockCache = [];
$this->temporalPosition = null;
@@ -2857,20 +2844,4 @@ class World implements ChunkManager, Metadatable{
}
}
}
public function setMetadata(string $metadataKey, MetadataValue $newMetadataValue) : void{
$this->server->getWorldMetadata()->setMetadata($this, $metadataKey, $newMetadataValue);
}
public function getMetadata(string $metadataKey){
return $this->server->getWorldMetadata()->getMetadata($this, $metadataKey);
}
public function hasMetadata(string $metadataKey) : bool{
return $this->server->getWorldMetadata()->hasMetadata($this, $metadataKey);
}
public function removeMetadata(string $metadataKey, Plugin $owningPlugin) : void{
$this->server->getWorldMetadata()->removeMetadata($this, $metadataKey, $owningPlugin);
}
}