mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-13 13:25:16 +00:00
Code Issues Projects Releases Wiki Activity

RegionLoader: improve performance of region header validation

Browse Source 
I was unaware that fseek actually makes a syscall which is rather costly, which became painfully obvious during large world conversions on PM4.
On average this problem appeared to be adding about 5ms to the load time for a newly loaded region, which is insanely expensive.
This commit is contained in:
Dylan K. Taylor 2021-01-20 20:04:21 +00:00
parent ea5931e274
commit ecc1e1f698
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pocketmine/level/format/io/region/RegionLoader.php
View File

@ -340,6 +340,8 @@ class RegionLoader{
/** @var int[] $usedOffsets */ /** @var int[] $usedOffsets */
$usedOffsets = []; $usedOffsets = [];
$fileSize = filesize($this->filePath);
if($fileSize === false) throw new AssumptionFailedError("filesize() should not return false here");
for($i = 0; $i < 1024; ++$i){ for($i = 0; $i < 1024; ++$i){
$entry = $this->locationTable[$i]; $entry = $this->locationTable[$i];
if($entry === null){ if($entry === null){
@ -352,8 +354,7 @@ class RegionLoader{
//TODO: more validity checks //TODO: more validity checks
fseek($this->filePointer, $fileOffset); if($fileOffset >= $fileSize){
if(feof($this->filePointer)){
throw new CorruptedRegionException("Region file location offset x=$x,z=$z points to invalid file location $fileOffset"); throw new CorruptedRegionException("Region file location offset x=$x,z=$z points to invalid file location $fileOffset");
} }
if(isset($usedOffsets[$offset])){ if(isset($usedOffsets[$offset])){