mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-25 12:54:03 +00:00
Code Issues Projects Releases Wiki Activity

GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers

Browse Source 
this would never crash, but in strongly typed code it would be a compile failure.
This commit is contained in:
Dylan K. Taylor 2019-12-01 09:33:12 +00:00
parent 47a959dace
commit ecbf3e9722
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pocketmine/command/defaults/GamemodeCommand.php
View File

@ -60,7 +60,6 @@ class GamemodeCommand extends VanillaCommand{
return true; return true;
} }
$target = $sender;
if(isset($args[1])){ if(isset($args[1])){
$target = $sender->getServer()->getPlayer($args[1]); $target = $sender->getServer()->getPlayer($args[1]);
if($target === null){ if($target === null){
@ -68,7 +67,9 @@ class GamemodeCommand extends VanillaCommand{
return true; return true;
} }
}elseif(!($sender instanceof Player)){ }elseif($sender instanceof Player){
$target = $sender;
}else{
throw new InvalidCommandSyntaxException(); throw new InvalidCommandSyntaxException();
} }