mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-03 08:39:53 +00:00
Code Issues Projects Releases Wiki Activity

UPnP: expose more functionality

Browse Source
This commit is contained in:
Dylan K. Taylor 2021-06-13 22:48:38 +01:00
parent 80bf948588
commit ec7ea98ead
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/network/upnp/UPnP.php
View File

@ -187,14 +187,14 @@ class UPnP{
return $serviceURL; return $serviceURL;
} }
public static function portForward(string $serviceURL, int $port) : void{ public static function portForward(string $serviceURL, string $internalIP, int $internalPort, int $externalPort) : void{
$body = $body =
'<u:AddPortMapping xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1">' . '<u:AddPortMapping xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1">' .
'<NewRemoteHost></NewRemoteHost>' . '<NewRemoteHost></NewRemoteHost>' .
'<NewExternalPort>' . $port . '</NewExternalPort>' . '<NewExternalPort>' . $externalPort . '</NewExternalPort>' .
'<NewProtocol>UDP</NewProtocol>' . '<NewProtocol>UDP</NewProtocol>' .
'<NewInternalPort>' . $port . '</NewInternalPort>' . '<NewInternalPort>' . $internalPort . '</NewInternalPort>' .
'<NewInternalClient>' . Internet::getInternalIP() . '</NewInternalClient>' . '<NewInternalClient>' . $internalIP . '</NewInternalClient>' .
'<NewEnabled>1</NewEnabled>' . '<NewEnabled>1</NewEnabled>' .
'<NewPortMappingDescription>PocketMine-MP</NewPortMappingDescription>' . '<NewPortMappingDescription>PocketMine-MP</NewPortMappingDescription>' .
'<NewLeaseDuration>0</NewLeaseDuration>' . '<NewLeaseDuration>0</NewLeaseDuration>' .
@ -215,11 +215,11 @@ class UPnP{
} }
} }
public static function removePortForward(string $serviceURL, int $port) : void{ public static function removePortForward(string $serviceURL, int $externalPort) : void{
$body = $body =
'<u:DeletePortMapping xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1">' . '<u:DeletePortMapping xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1">' .
'<NewRemoteHost></NewRemoteHost>' . '<NewRemoteHost></NewRemoteHost>' .
'<NewExternalPort>' . $port . '</NewExternalPort>' . '<NewExternalPort>' . $externalPort . '</NewExternalPort>' .
'<NewProtocol>UDP</NewProtocol>' . '<NewProtocol>UDP</NewProtocol>' .
'</u:DeletePortMapping>'; '</u:DeletePortMapping>';

2
src/network/upnp/UPnPNetworkInterface.php
View File

@ -52,7 +52,7 @@ final class UPnPNetworkInterface implements NetworkInterface{
$this->logger->info("Attempting to portforward..."); $this->logger->info("Attempting to portforward...");
$this->serviceURL = UPnP::getServiceUrl(); $this->serviceURL = UPnP::getServiceUrl();
UPnP::portForward($this->serviceURL, $this->port); UPnP::portForward($this->serviceURL, Internet::getInternalIP(), $this->port, $this->port);
$this->logger->info("Forwarded $this->ip:$this->port to external port $this->port"); $this->logger->info("Forwarded $this->ip:$this->port to external port $this->port");
} }