From ec28612a1252a8d036e4f9f2b03aeafbc59d3029 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Fri, 1 Jun 2018 17:08:58 +0100 Subject: [PATCH] BlockFactory: partial revert of 515e4aabc45c057e215e5f695a94a7bd7b0e1094 it's necessary to register these to fill the static property arrays. Someday these won't be necessary I hope... --- src/pocketmine/block/BlockFactory.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/block/BlockFactory.php b/src/pocketmine/block/BlockFactory.php index 0cc88463e..cfa0e88ae 100644 --- a/src/pocketmine/block/BlockFactory.php +++ b/src/pocketmine/block/BlockFactory.php @@ -323,6 +323,12 @@ class BlockFactory{ //TODO: STRUCTURE_BLOCK //TODO: RESERVED6 + + for($id = 0, $size = self::$fullList->getSize() >> 4; $id < $size; ++$id){ + if(self::$fullList[$id << 4] === null){ + self::registerBlock(new UnknownBlock($id)); + } + } } /** @@ -375,8 +381,8 @@ class BlockFactory{ } try{ - if(self::$fullList !== null and self::$fullList[$idx = ($id << 4) | $meta] !== null){ - $block = clone self::$fullList[$idx]; + if(self::$fullList !== null){ + $block = clone self::$fullList[($id << 4) | $meta]; }else{ $block = new UnknownBlock($id, $meta); }