mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-13 15:05:33 +00:00
Code Issues Projects Releases Wiki Activity

Don't hold player references for hiddenPlayers

Browse Source 
they aren't needed, and this is just one more thing that could go wrong in Player->close() that could lead to leaks.
This commit is contained in:
Dylan K. Taylor 2017-10-09 09:20:34 +01:00
parent 119913da30
commit ebcce43131
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/Player.php
View File

@ -264,7 +264,7 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
protected $loadQueue = []; protected $loadQueue = [];
protected $nextChunkOrderRun = 5; protected $nextChunkOrderRun = 5;
/** @var Player[] */ /** @var bool[] map: raw UUID (string) => bool */
protected $hiddenPlayers = []; protected $hiddenPlayers = [];
/** @var Vector3|null */ /** @var Vector3|null */
@ -503,7 +503,7 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
if($player === $this){ if($player === $this){
return; return;
} }
$this->hiddenPlayers[$player->getRawUniqueId()] = $player; $this->hiddenPlayers[$player->getRawUniqueId()] = true;
$player->despawnFrom($this); $player->despawnFrom($this);
} }