mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

Further refactors to prepare for y=-64 lower limit

Browse Source
This commit is contained in:
Dylan K. Taylor
2021-03-18 00:08:16 +00:00
parent b844c4266d
commit eb9a68edee
17 changed files with 101 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/world/light/SkyLightUpdate.php
View File

@ -178,7 +178,7 @@ class SkyLightUpdate extends LightUpdate{
break;
}
}
$result = HeightArray::fill(0);
$result = HeightArray::fill(World::Y_MIN);
if($maxSubChunkY === -1){ //whole column is definitely empty
return $result;
}
@ -188,16 +188,16 @@ class SkyLightUpdate extends LightUpdate{
$y = null;
for($subChunkY = $maxSubChunkY; $subChunkY >= 0; $subChunkY--){
$subHighestBlockY = $chunk->getSubChunk($subChunkY)->getHighestBlockAt($x, $z);
if($subHighestBlockY !== -1){
if($subHighestBlockY !== null){
$y = ($subChunkY * 16) + $subHighestBlockY;
break;
}
}
if($y === null){ //no blocks in the column
$result->set($x, $z, 0);
$result->set($x, $z, World::Y_MIN);
}else{
for(; $y >= 0; --$y){
for(; $y >= World::Y_MIN; --$y){
if($directSkyLightBlockers[$chunk->getFullBlock($x, $y, $z)]){
$result->set($x, $z, $y + 1);
break;
@ -221,7 +221,10 @@ class SkyLightUpdate extends LightUpdate{
*/
private static function recalculateHeightMapColumn(Chunk $chunk, int $x, int $z, \SplFixedArray $directSkyLightBlockers) : int{
$y = $chunk->getHighestBlockAt($x, $z);
for(; $y >= 0; --$y){
if($y === null){
return World::Y_MIN;
}
for(; $y >= World::Y_MIN; --$y){
if($directSkyLightBlockers[$chunk->getFullBlock($x, $y, $z)]){
break;
}