mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-18 19:55:33 +00:00
Code Issues Projects Releases Wiki Activity

Player: remove useless check from save()

Browse Source 
this exception is only thrown if the player is closed, which is already unexpected in the first place and will actually crash if it's not kosher. This prevents doing stuff like saving players during onDispose(), which crashes the server if a player is disconnected due to flagForDespawn().
This commit is contained in:
Dylan K. Taylor 2021-01-07 23:32:35 +00:00
parent 7b806e74b8
commit eaaed79b93
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/player/Player.php
View File

@ -2033,14 +2033,8 @@ class Player extends Human implements CommandSender, ChunkListener, IPlayer{
/** /**
* Handles player data saving * Handles player data saving
*
* @throws \InvalidStateException if the player is closed
*/ */
public function save() : void{ public function save() : void{
if($this->closed){
throw new \InvalidStateException("Tried to save closed player");
}
$nbt = $this->saveNBT(); $nbt = $this->saveNBT();
if($this->location->isValid()){ if($this->location->isValid()){