mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 01:46:04 +00:00
Code Issues Projects Releases Wiki Activity

NetworkSession: do not expose setPlayerInfo()

Browse Source
This commit is contained in:
Dylan K. Taylor
2020-04-16 01:55:52 +01:00
parent 9ba47f90d1
commit e86c243db5
2 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/network/mcpe/handler/LoginPacketHandler.php
View File

@ -50,10 +50,19 @@ class LoginPacketHandler extends PacketHandler{
private $server;
/** @var NetworkSession */
private $session;
/**
* @var \Closure
* @phpstan-var \Closure(PlayerInfo) : void
*/
private $playerInfoConsumer;
public function __construct(Server $server, NetworkSession $session){
/**
* @phpstan-param \Closure(PlayerInfo) : void $playerInfoConsumer
*/
public function __construct(Server $server, NetworkSession $session, \Closure $playerInfoConsumer){
$this->session = $session;
$this->server = $server;
$this->playerInfoConsumer = $playerInfoConsumer;
}
public function handleLogin(LoginPacket $packet) : bool{
@ -117,7 +126,7 @@ class LoginPacketHandler extends PacketHandler{
}catch(\InvalidArgumentException $e){
throw BadPacketException::wrap($e, "Failed to parse login UUID");
}
$this->session->setPlayerInfo(new PlayerInfo(
($this->playerInfoConsumer)(new PlayerInfo(
$packet->extraData->displayName,
$uuid,
$skin,