From e7771d76f2fb9d0d9561f5c02a45035eab6c3dc4 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 20 Mar 2023 23:29:02 +0000 Subject: [PATCH] Cover buffered inventory sync in timings --- src/network/mcpe/NetworkSession.php | 7 ++++++- src/timings/Timings.php | 4 ++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/network/mcpe/NetworkSession.php b/src/network/mcpe/NetworkSession.php index 99ba222b2..2d628c839 100644 --- a/src/network/mcpe/NetworkSession.php +++ b/src/network/mcpe/NetworkSession.php @@ -1146,7 +1146,12 @@ class NetworkSession{ $attribute->markSynchronized(); } } - $this->invManager?->flushPendingUpdates(); + Timings::$playerNetworkSendInventorySync->startTiming(); + try{ + $this->invManager?->flushPendingUpdates(); + }finally{ + Timings::$playerNetworkSendInventorySync->stopTiming(); + } $this->flushSendBuffer(); } diff --git a/src/timings/Timings.php b/src/timings/Timings.php index 3359a2eeb..668860132 100644 --- a/src/timings/Timings.php +++ b/src/timings/Timings.php @@ -56,6 +56,9 @@ abstract class Timings{ /** @var TimingsHandler */ public static $playerNetworkSendEncrypt; + + public static TimingsHandler $playerNetworkSendInventorySync; + /** @var TimingsHandler */ public static $playerNetworkReceive; /** @var TimingsHandler */ @@ -170,6 +173,7 @@ abstract class Timings{ self::$playerNetworkSendCompressBroadcast = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Player Network Send - Compression (Broadcast)", self::$playerNetworkSendCompress); self::$playerNetworkSendCompressSessionBuffer = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Player Network Send - Compression (Session Buffer)", self::$playerNetworkSendCompress); self::$playerNetworkSendEncrypt = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Player Network Send - Encryption", self::$playerNetworkSend); + self::$playerNetworkSendInventorySync = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Player Network Send - Inventory Sync", self::$playerNetworkSend); self::$playerNetworkReceive = new TimingsHandler("Player Network Receive", self::$connection); self::$playerNetworkReceiveDecompress = new TimingsHandler(self::INCLUDED_BY_OTHER_TIMINGS_PREFIX . "Player Network Receive - Decompression", self::$playerNetworkReceive);