From e6fb6b1f27048bd5e722c4cdbab01d83c0bf9fab Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 15 Apr 2021 15:15:16 +0100 Subject: [PATCH] BaseLevelProvider: Remove obsolete proxy methods --- src/world/format/io/BaseWorldProvider.php | 20 ------------------- src/world/format/io/leveldb/LevelDB.php | 4 ++-- .../format/io/region/RegionWorldProvider.php | 4 ++-- 3 files changed, 4 insertions(+), 24 deletions(-) diff --git a/src/world/format/io/BaseWorldProvider.php b/src/world/format/io/BaseWorldProvider.php index 4726402830..6404f641b8 100644 --- a/src/world/format/io/BaseWorldProvider.php +++ b/src/world/format/io/BaseWorldProvider.php @@ -23,8 +23,6 @@ declare(strict_types=1); namespace pocketmine\world\format\io; -use pocketmine\world\format\Chunk; -use pocketmine\world\format\io\exception\CorruptedChunkException; use pocketmine\world\format\io\exception\CorruptedWorldException; use pocketmine\world\format\io\exception\UnsupportedWorldFormatException; use pocketmine\world\WorldException; @@ -58,22 +56,4 @@ abstract class BaseWorldProvider implements WorldProvider{ public function getWorldData() : WorldData{ return $this->worldData; } - - /** - * @throws CorruptedChunkException - */ - public function loadChunk(int $chunkX, int $chunkZ) : ?Chunk{ - return $this->readChunk($chunkX, $chunkZ); - } - - public function saveChunk(int $chunkX, int $chunkZ, Chunk $chunk) : void{ - $this->writeChunk($chunkX, $chunkZ, $chunk); - } - - /** - * @throws CorruptedChunkException - */ - abstract protected function readChunk(int $chunkX, int $chunkZ) : ?Chunk; - - abstract protected function writeChunk(int $chunkX, int $chunkZ, Chunk $chunk) : void; } diff --git a/src/world/format/io/leveldb/LevelDB.php b/src/world/format/io/leveldb/LevelDB.php index 56011bee15..1adf76db94 100644 --- a/src/world/format/io/leveldb/LevelDB.php +++ b/src/world/format/io/leveldb/LevelDB.php @@ -230,7 +230,7 @@ class LevelDB extends BaseWorldProvider implements WritableWorldProvider{ /** * @throws CorruptedChunkException */ - protected function readChunk(int $chunkX, int $chunkZ) : ?Chunk{ + public function loadChunk(int $chunkX, int $chunkZ) : ?Chunk{ $index = LevelDB::chunkIndex($chunkX, $chunkZ); $chunkVersionRaw = $this->db->get($index . self::TAG_VERSION); @@ -418,7 +418,7 @@ class LevelDB extends BaseWorldProvider implements WritableWorldProvider{ return $chunk; } - protected function writeChunk(int $chunkX, int $chunkZ, Chunk $chunk) : void{ + public function saveChunk(int $chunkX, int $chunkZ, Chunk $chunk) : void{ $idMap = LegacyBlockIdToStringIdMap::getInstance(); $index = LevelDB::chunkIndex($chunkX, $chunkZ); diff --git a/src/world/format/io/region/RegionWorldProvider.php b/src/world/format/io/region/RegionWorldProvider.php index c02f37739b..a54fce73ef 100644 --- a/src/world/format/io/region/RegionWorldProvider.php +++ b/src/world/format/io/region/RegionWorldProvider.php @@ -207,7 +207,7 @@ abstract class RegionWorldProvider extends BaseWorldProvider{ /** * @throws CorruptedChunkException */ - protected function readChunk(int $chunkX, int $chunkZ) : ?Chunk{ + public function loadChunk(int $chunkX, int $chunkZ) : ?Chunk{ $regionX = $regionZ = null; self::getRegionIndex($chunkX, $chunkZ, $regionX, $regionZ); assert(is_int($regionX) and is_int($regionZ)); @@ -224,7 +224,7 @@ abstract class RegionWorldProvider extends BaseWorldProvider{ return null; } - protected function writeChunk(int $chunkX, int $chunkZ, Chunk $chunk) : void{ + public function saveChunk(int $chunkX, int $chunkZ, Chunk $chunk) : void{ self::getRegionIndex($chunkX, $chunkZ, $regionX, $regionZ); $this->loadRegion($regionX, $regionZ)->writeChunk($chunkX & 0x1f, $chunkZ & 0x1f, $this->serializeChunk($chunk)); }