make logic for fetching handler lists more consistent

This commit is contained in:
Dylan K. Taylor
2019-08-23 17:16:07 +01:00
parent 7e5193355e
commit e5b02ee5e0
10 changed files with 272 additions and 30 deletions

View File

@@ -568,19 +568,6 @@ class PluginManager{
$timings = new TimingsHandler("Plugin: " . $plugin->getDescription()->getFullName() . " Event: " . $handlerName . "(" . (new \ReflectionClass($event))->getShortName() . ")");
$this->getEventListeners($event)->register(new RegisteredListener($handler, $priority, $plugin, $handleCancelled, $timings));
}
/**
* @param string $event
*
* @return HandlerList
*/
private function getEventListeners(string $event) : HandlerList{
$list = HandlerListManager::global()->getListFor($event);
if($list === null){
throw new PluginException("Abstract events not declaring @allowHandle cannot be handled (tried to register listener for $event)");
}
return $list;
HandlerListManager::global()->getListFor($event)->register(new RegisteredListener($handler, $priority, $plugin, $handleCancelled, $timings));
}
}