mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 20:28:31 +00:00
Code Issues Projects Releases Wiki Activity

Tile: remove unnecessary createAdditionalNBT() things

Browse Source 
these things are filled in by the tiles' constructors anyway.
This commit is contained in:
Dylan K. Taylor 2018-04-13 11:50:04 +01:00
parent 556a465c05
commit e565cdeea4
3 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/pocketmine/tile/FlowerPot.php
View File

@ -26,11 +26,9 @@ namespace pocketmine\tile;
use pocketmine\item\Item; use pocketmine\item\Item;
use pocketmine\item\ItemFactory; use pocketmine\item\ItemFactory;
use pocketmine\level\Level; use pocketmine\level\Level;
use pocketmine\math\Vector3;
use pocketmine\nbt\tag\CompoundTag; use pocketmine\nbt\tag\CompoundTag;
use pocketmine\nbt\tag\IntTag; use pocketmine\nbt\tag\IntTag;
use pocketmine\nbt\tag\ShortTag; use pocketmine\nbt\tag\ShortTag;
use pocketmine\Player;
class FlowerPot extends Spawnable{ class FlowerPot extends Spawnable{
public const TAG_ITEM = "item"; public const TAG_ITEM = "item";
@ -92,9 +90,4 @@ class FlowerPot extends Spawnable{
$nbt->setTag($this->namedtag->getTag(self::TAG_ITEM)); $nbt->setTag($this->namedtag->getTag(self::TAG_ITEM));
$nbt->setTag($this->namedtag->getTag(self::TAG_ITEM_DATA)); $nbt->setTag($this->namedtag->getTag(self::TAG_ITEM_DATA));
} }
protected static function createAdditionalNBT(CompoundTag $nbt, Vector3 $pos, ?int $face = null, ?Item $item = null, ?Player $player = null) : void{
$nbt->setShort(self::TAG_ITEM, 0);
$nbt->setInt(self::TAG_ITEM_DATA, 0);
}
} }

7
src/pocketmine/tile/ItemFrame.php
View File

@ -26,11 +26,9 @@ namespace pocketmine\tile;
use pocketmine\item\Item; use pocketmine\item\Item;
use pocketmine\item\ItemFactory; use pocketmine\item\ItemFactory;
use pocketmine\level\Level; use pocketmine\level\Level;
use pocketmine\math\Vector3;
use pocketmine\nbt\tag\ByteTag; use pocketmine\nbt\tag\ByteTag;
use pocketmine\nbt\tag\CompoundTag; use pocketmine\nbt\tag\CompoundTag;
use pocketmine\nbt\tag\FloatTag; use pocketmine\nbt\tag\FloatTag;
use pocketmine\Player;
class ItemFrame extends Spawnable{ class ItemFrame extends Spawnable{
public const TAG_ITEM_ROTATION = "ItemRotation"; public const TAG_ITEM_ROTATION = "ItemRotation";
@ -97,9 +95,4 @@ class ItemFrame extends Spawnable{
$nbt->setTag($this->namedtag->getTag(self::TAG_ITEM)); $nbt->setTag($this->namedtag->getTag(self::TAG_ITEM));
} }
} }
protected static function createAdditionalNBT(CompoundTag $nbt, Vector3 $pos, ?int $face = null, ?Item $item = null, ?Player $player = null) : void{
$nbt->setFloat(self::TAG_ITEM_DROP_CHANCE, 1.0);
$nbt->setByte(self::TAG_ITEM_ROTATION, 0);
}
} }

5
src/pocketmine/tile/Sign.php
View File

@ -171,13 +171,8 @@ class Sign extends Spawnable{
} }
protected static function createAdditionalNBT(CompoundTag $nbt, Vector3 $pos, ?int $face = null, ?Item $item = null, ?Player $player = null) : void{ protected static function createAdditionalNBT(CompoundTag $nbt, Vector3 $pos, ?int $face = null, ?Item $item = null, ?Player $player = null) : void{
for($i = 1; $i <= 4; ++$i){
$nbt->setString(sprintf(self::TAG_TEXT_LINE, $i), "");
}
if($player !== null){ if($player !== null){
$nbt->setString(self::TAG_CREATOR, $player->getRawUniqueId()); $nbt->setString(self::TAG_CREATOR, $player->getRawUniqueId());
} }
} }
} }