Network: clean up ticking handling, RakLib only processes on Snooze notification

src/pocketmine/Server.php

@@ -2537,7 +2537,7 @@ class Server{
 		++$this->tickCounter;
 
 		Timings::$connectionTimer->startTiming();
-		$this->network->processInterfaces();
+		$this->network->tickInterfaces();
 		Timings::$connectionTimer->stopTiming();
 
 		Timings::$schedulerTimer->startTiming();

src/pocketmine/network/Network.php

@@ -80,16 +80,11 @@ class Network{
 		return $this->interfaces;
 	}
 
-	public function processInterfaces() : void{
+	public function tickInterfaces() : void{
 		foreach($this->interfaces as $interface){
-			$this->processInterface($interface);
-		}
-	}
-
-	public function processInterface(NetworkInterface $interface) : void{
 			try{
-			$interface->process();
+				$interface->tick();
-		}catch(\Throwable $e){
+			}catch(\Exception $e){
 				$logger = $this->server->getLogger();
 				if(\pocketmine\DEBUG > 1){
 					$logger->logException($e);
@@ -102,6 +97,7 @@ class Network{
 				$logger->critical($this->server->getLanguage()->translateString("pocketmine.server.networkError", [get_class($interface), $e->getMessage()]));
 			}
 		}
+	}
 
 	/**
 	 * @param NetworkInterface $interface

src/pocketmine/network/NetworkInterface.php

@@ -63,7 +63,7 @@ interface NetworkInterface{
 	/**
 	 * Called every tick to process events on the interface.
 	 */
-	public function process() : void;
+	public function tick() : void;
 
 	/**
 	 * Gracefully shuts down the network interface.

src/pocketmine/network/mcpe/RakLibInterface.php

@@ -71,7 +71,8 @@ class RakLibInterface implements ServerInstance, AdvancedNetworkInterface{
 
 		$this->sleeper = new SleeperNotifier();
 		$server->getTickSleeper()->addNotifier($this->sleeper, function() : void{
-			$this->server->getNetwork()->processInterface($this);
+			//this should not throw any exception. If it does, this should crash the server since it's a fault condition.
+			while($this->interface->handlePacket());
 		});
 
 		$this->rakLib = new RakLibServer(
@@ -93,9 +94,7 @@ class RakLibInterface implements ServerInstance, AdvancedNetworkInterface{
 		$this->network = $network;
 	}
 
-	public function process() : void{
+	public function tick() : void{
-		while($this->interface->handlePacket()){}
-
 		if(!$this->rakLib->isRunning() and !$this->rakLib->isShutdown()){
 			throw new \Exception("RakLib Thread crashed");
 		}