From 829dd02eea55c7d67fed64c462c54a88430b0f8f Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 1 Feb 2020 19:30:47 +0000 Subject: [PATCH 1/2] Server: fixed more bad non-nullable phpdocs --- src/pocketmine/Server.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pocketmine/Server.php b/src/pocketmine/Server.php index b25faf370..4ca6c8eed 100644 --- a/src/pocketmine/Server.php +++ b/src/pocketmine/Server.php @@ -1588,7 +1588,7 @@ class Server{ /** * @param TextContainer|string $message - * @param CommandSender[] $recipients + * @param CommandSender[]|null $recipients */ public function broadcastMessage($message, array $recipients = null) : int{ if(!is_array($recipients)){ @@ -1603,7 +1603,7 @@ class Server{ } /** - * @param Player[] $recipients + * @param Player[]|null $recipients */ public function broadcastTip(string $tip, array $recipients = null) : int{ if(!is_array($recipients)){ @@ -1624,7 +1624,7 @@ class Server{ } /** - * @param Player[] $recipients + * @param Player[]|null $recipients */ public function broadcastPopup(string $popup, array $recipients = null) : int{ if(!is_array($recipients)){ From 0a566f8218bc1391a9c9b54741948951c33a6a35 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 1 Feb 2020 20:16:05 +0000 Subject: [PATCH 2/2] LevelProvider::generate() accepts class-string, not any string --- src/pocketmine/level/format/io/LevelProvider.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pocketmine/level/format/io/LevelProvider.php b/src/pocketmine/level/format/io/LevelProvider.php index 68d101ae2..b35613de6 100644 --- a/src/pocketmine/level/format/io/LevelProvider.php +++ b/src/pocketmine/level/format/io/LevelProvider.php @@ -26,6 +26,7 @@ namespace pocketmine\level\format\io; use pocketmine\level\format\Chunk; use pocketmine\level\format\io\exception\CorruptedChunkException; use pocketmine\level\format\io\exception\UnsupportedChunkFormatException; +use pocketmine\level\generator\Generator; use pocketmine\math\Vector3; interface LevelProvider{ @@ -54,7 +55,8 @@ interface LevelProvider{ * Generate the needed files in the path given * * @param mixed[] $options - * @phpstan-param array $options + * @phpstan-param class-string $generator + * @phpstan-param array $options * * @return void */