mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 02:08:21 +00:00
Code Issues Projects Releases Wiki Activity

block: eliminate suspicious usages of $blockClicked in place()

Browse Source
This commit is contained in:
Dylan K. Taylor
2023-01-12 20:35:26 +00:00
parent 4e9c3e101d
commit e26c8b9e9f
7 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/block/Ladder.php
View File

@ -70,7 +70,7 @@ class Ladder extends Transparent{
}
public function place(BlockTransaction $tx, Item $item, Block $blockReplace, Block $blockClicked, int $face, Vector3 $clickVector, ?Player $player = null) : bool{
if($this->canBeSupportedBy($blockClicked, $face) && Facing::axis($face) !== Axis::Y){
if($this->canBeSupportedBy($blockReplace->getSide(Facing::opposite($face)), $face) && Facing::axis($face) !== Axis::Y){
$this->facing = $face;
return parent::place($tx, $item, $blockReplace, $blockClicked, $face, $clickVector, $player);
}