From 2cb6990698e2575e0b64fef7e5172d9dd9694ff6 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 14 Dec 2019 10:04:51 +0000 Subject: [PATCH] Enchantment: don't throw exceptions on out of range IDs this function is used for data deserialization, and data may have bad enchantment IDs in it. --- src/pocketmine/item/enchantment/Enchantment.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pocketmine/item/enchantment/Enchantment.php b/src/pocketmine/item/enchantment/Enchantment.php index 58dfba841..3e1de4219 100644 --- a/src/pocketmine/item/enchantment/Enchantment.php +++ b/src/pocketmine/item/enchantment/Enchantment.php @@ -155,6 +155,9 @@ class Enchantment{ * @return Enchantment|null */ public static function getEnchantment(int $id) : ?Enchantment{ + if($id < 0 or $id >= self::$enchantments->getSize()){ + return null; + } return self::$enchantments[$id] ?? null; }