mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-11 04:17:48 +00:00
Code Issues Projects Releases Wiki Activity

ProcessLoginTask: remove dead comments

Browse Source 
This is no longer an issue since b2df405cc0355dcffe202bc4040fae316940d427.
This commit is contained in:
Dylan K. Taylor 2023-12-15 16:01:43 +00:00
parent d3d7f24015
commit e1f4fd3048
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/network/mcpe/auth/ProcessLoginTask.php
View File

@ -128,7 +128,6 @@ class ProcessLoginTask extends AsyncTask{
try{ try{
[$headersArray, $claimsArray, ] = JwtUtils::parse($jwt); [$headersArray, $claimsArray, ] = JwtUtils::parse($jwt);
}catch(JwtException $e){ }catch(JwtException $e){
//TODO: we shouldn't be showing internal information like this to the client
throw new VerifyLoginException("Failed to parse JWT: " . $e->getMessage(), null, 0, $e); throw new VerifyLoginException("Failed to parse JWT: " . $e->getMessage(), null, 0, $e);
} }
@ -141,13 +140,11 @@ class ProcessLoginTask extends AsyncTask{
/** @var JwtHeader $headers */ /** @var JwtHeader $headers */
$headers = $mapper->map($headersArray, new JwtHeader()); $headers = $mapper->map($headersArray, new JwtHeader());
}catch(\JsonMapper_Exception $e){ }catch(\JsonMapper_Exception $e){
//TODO: we shouldn't be showing internal information like this to the client
throw new VerifyLoginException("Invalid JWT header: " . $e->getMessage(), null, 0, $e); throw new VerifyLoginException("Invalid JWT header: " . $e->getMessage(), null, 0, $e);
} }
$headerDerKey = base64_decode($headers->x5u, true); $headerDerKey = base64_decode($headers->x5u, true);
if($headerDerKey === false){ if($headerDerKey === false){
//TODO: we shouldn't be showing internal information like this to the client
throw new VerifyLoginException("Invalid JWT public key: base64 decoding error decoding x5u"); throw new VerifyLoginException("Invalid JWT public key: base64 decoding error decoding x5u");
} }
@ -163,7 +160,6 @@ class ProcessLoginTask extends AsyncTask{
try{ try{
$signingKeyOpenSSL = JwtUtils::parseDerPublicKey($headerDerKey); $signingKeyOpenSSL = JwtUtils::parseDerPublicKey($headerDerKey);
}catch(JwtException $e){ }catch(JwtException $e){
//TODO: we shouldn't be showing this internal information to the client
throw new VerifyLoginException("Invalid JWT public key: " . $e->getMessage(), null, 0, $e); throw new VerifyLoginException("Invalid JWT public key: " . $e->getMessage(), null, 0, $e);
} }
try{ try{