mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-24 03:44:08 +00:00
Code Issues Projects Releases Wiki Activity

Chunk: remove useless instanceof checks

Browse Source 
these are always CompoundTags, and if they aren't we have a bug somewhere else.
This commit is contained in:
Dylan K. Taylor 2020-02-05 20:44:27 +00:00
parent 2f325b8c91
commit e1ddf90695
1 changed files with 18 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/level/format/Chunk.php
View File

@ -687,7 +687,6 @@ class Chunk{
$level->timings->syncChunkLoadEntitiesTimer->startTiming(); $level->timings->syncChunkLoadEntitiesTimer->startTiming();
foreach($this->NBTentities as $nbt){ foreach($this->NBTentities as $nbt){
if($nbt instanceof CompoundTag){
if(!$nbt->hasTag("id")){ //allow mixed types (because of leveldb) if(!$nbt->hasTag("id")){ //allow mixed types (because of leveldb)
$changed = true; $changed = true;
continue; continue;
@ -705,13 +704,11 @@ class Chunk{
continue; continue;
} }
} }
}
$this->NBTentities = []; $this->NBTentities = [];
$level->timings->syncChunkLoadEntitiesTimer->stopTiming(); $level->timings->syncChunkLoadEntitiesTimer->stopTiming();
$level->timings->syncChunkLoadTileEntitiesTimer->startTiming(); $level->timings->syncChunkLoadTileEntitiesTimer->startTiming();
foreach($this->NBTtiles as $nbt){ foreach($this->NBTtiles as $nbt){
if($nbt instanceof CompoundTag){
if(!$nbt->hasTag(Tile::TAG_ID, StringTag::class)){ if(!$nbt->hasTag(Tile::TAG_ID, StringTag::class)){
$changed = true; $changed = true;
continue; continue;
@ -722,7 +719,6 @@ class Chunk{
continue; continue;
} }
} }
}
$this->NBTtiles = []; $this->NBTtiles = [];
$level->timings->syncChunkLoadTileEntitiesTimer->stopTiming(); $level->timings->syncChunkLoadTileEntitiesTimer->stopTiming();