From e088da320cc5c4e3cf283e83ad05acb652bec2ba Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 23 Mar 2019 19:06:35 +0000 Subject: [PATCH] ItemEntity: fixed mineWood achievement not working for acacia/dark-oak --- src/pocketmine/entity/object/ItemEntity.php | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/pocketmine/entity/object/ItemEntity.php b/src/pocketmine/entity/object/ItemEntity.php index 74baf8e48..c01a49618 100644 --- a/src/pocketmine/entity/object/ItemEntity.php +++ b/src/pocketmine/entity/object/ItemEntity.php @@ -23,11 +23,13 @@ declare(strict_types=1); namespace pocketmine\entity\object; +use pocketmine\block\Wood; use pocketmine\entity\Entity; use pocketmine\event\entity\ItemDespawnEvent; use pocketmine\event\entity\ItemSpawnEvent; use pocketmine\event\inventory\InventoryPickupItemEvent; use pocketmine\item\Item; +use pocketmine\item\ItemIds; use pocketmine\nbt\tag\CompoundTag; use pocketmine\network\mcpe\protocol\AddItemEntityPacket; use pocketmine\network\mcpe\protocol\TakeItemEntityPacket; @@ -260,13 +262,10 @@ class ItemEntity extends Entity{ return; } - switch($item->getId()){ - case Item::WOOD: - $player->awardAchievement("mineWood"); - break; - case Item::DIAMOND: - $player->awardAchievement("diamond"); - break; + if($item->getBlock() instanceof Wood){ + $player->awardAchievement("mineWood"); + }elseif($item->getId() === ItemIds::DIAMOND){ + $player->awardAchievement("diamond"); } $pk = new TakeItemEntityPacket();