mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

Modernize private property declarations in Threaded classes

Browse Source 
I previously avoided this due to being unsure of the effects; however, it's clear that we already use typed properties on Threaded things in other places anyway, and the only known issues are with uninit properties, and arrays.
This commit is contained in:
Dylan K. Taylor
2022-05-17 22:42:18 +01:00
parent d4b7f66e15
commit df3a69dcb7
9 changed files with 37 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/network/mcpe/compression/CompressBatchTask.php
View File

@ -29,14 +29,11 @@ class CompressBatchTask extends AsyncTask{
private const TLS_KEY_PROMISE = "promise";
/** @var string */
private $data;
/** @var Compressor */
private $compressor;
public function __construct(string $data, CompressBatchPromise $promise, Compressor $compressor){
$this->data = $data;
$this->compressor = $compressor;
public function __construct(
private string $data,
CompressBatchPromise $promise,
private Compressor $compressor
){
$this->storeLocal(self::TLS_KEY_PROMISE, $promise);
}