From dec6f73f2f9abc08c5b51133599a5d1edff2d0b2 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Tue, 6 Aug 2019 10:18:02 +0100 Subject: [PATCH] Remove unnecessary BannerPattern copying on block clone --- src/block/Banner.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/block/Banner.php b/src/block/Banner.php index 96151917d..32728041a 100644 --- a/src/block/Banner.php +++ b/src/block/Banner.php @@ -36,7 +36,6 @@ use pocketmine\math\AxisAlignedBB; use pocketmine\math\Facing; use pocketmine\math\Vector3; use pocketmine\player\Player; -use pocketmine\utils\Utils; use pocketmine\world\BlockTransaction; use function assert; use function floor; @@ -67,7 +66,8 @@ class Banner extends Transparent{ public function __clone(){ parent::__clone(); - $this->patterns = $this->patterns->map(Utils::cloneCallback()); + //pattern objects are considered immutable, so they don't need to be copied + $this->patterns = $this->patterns->copy(); } public function getId() : int{