mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-11 00:09:39 +00:00
Code Issues Projects Releases Wiki Activity

World: don't create a new chunk just to read biome info

Browse Source 
the chunk won't be generated, so we can provide the default result without creating a new chunk for no reason.
This commit is contained in:
Dylan K. Taylor 2020-10-31 21:29:39 +00:00
parent de867f1b86
commit dec235abab
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/world/World.php
View File

@ -1858,7 +1858,10 @@ class World implements ChunkManager{
}
public function getBiomeId(int $x, int $z) : int{
return $this->getOrLoadChunk($x >> 4, $z >> 4, true)->getBiomeId($x & 0x0f, $z & 0x0f);
if(($chunk = $this->getOrLoadChunk($x >> 4, $z >> 4, false)) !== null){
return $chunk->getBiomeId($x & 0x0f, $z & 0x0f);
}
return Biome::OCEAN; //TODO: this should probably throw instead (terrain not generated yet)
}
public function getBiome(int $x, int $z) : Biome{