mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-13 13:25:16 +00:00
Code Issues Projects Releases Wiki Activity

Player: Use fmod() instead of modulo operator for yaw/pitch

Browse Source 
the modulo (%) operator only operates on integers. If it's used on floats, they are silently casted to ints, which results in loss of accuracy. Fractions of a degree might not seem important, but for ray-tracing purposes a fraction of a degree can make the difference between hit and miss.
This commit is contained in:
Dylan K. Taylor 2017-12-24 19:48:43 +00:00
parent 1edf69892a
commit ddbc5cf960
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/Player.php
View File

@ -2148,8 +2148,8 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
$this->isTeleporting = false; $this->isTeleporting = false;
} }
$packet->yaw %= 360; $packet->yaw = fmod($packet->yaw, 360);
$packet->pitch %= 360; $packet->pitch = fmod($packet->pitch, 360);
if($packet->yaw < 0){ if($packet->yaw < 0){
$packet->yaw += 360; $packet->yaw += 360;