mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-04 08:56:15 +00:00
Code Issues Projects Releases Wiki Activity

Block->getBreakTime() now throws InvalidArgumentException on items with bad efficiency values

Browse Source
This commit is contained in:
Dylan K. Taylor
2019-01-30 19:10:24 +00:00
parent d3704bfae4
commit ddbb5363ef
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/block/Block.php
View File

@ -39,6 +39,7 @@ use pocketmine\metadata\MetadataValue;
use pocketmine\Player; use pocketmine\Player;
use pocketmine\plugin\Plugin; use pocketmine\plugin\Plugin;
use function array_merge; use function array_merge;
use function get_class;
use const PHP_INT_MAX; use const PHP_INT_MAX;
class Block extends Position implements BlockIds, Metadatable{ class Block extends Position implements BlockIds, Metadatable{
@ -268,6 +269,7 @@ class Block extends Position implements BlockIds, Metadatable{
* @param Item $item * @param Item $item
* *
* @return float * @return float
* @throws \InvalidArgumentException if the item efficiency is not a positive number
*/ */
public function getBreakTime(Item $item) : float{ public function getBreakTime(Item $item) : float{
$base = $this->getHardness(); $base = $this->getHardness();
@ -279,7 +281,7 @@ class Block extends Position implements BlockIds, Metadatable{
$efficiency = $item->getMiningEfficiency($this); $efficiency = $item->getMiningEfficiency($this);
if($efficiency <= 0){ if($efficiency <= 0){
throw new \RuntimeException("Item efficiency is invalid"); throw new \InvalidArgumentException(get_class($item) . " has invalid mining efficiency: expected >= 0, got $efficiency");
} }
$base /= $efficiency; $base /= $efficiency;