mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-14 01:39:52 +00:00
Code Issues Projects Releases Wiki Activity

BlockFactory: don't pre-populate gaps with UnknownBlock objects

Browse Source 
this produces a minor reduction in memory usage.
This commit is contained in:
Dylan K. Taylor 2018-09-19 15:17:39 +01:00
parent ef038d9625
commit dbe0ee2d44
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pocketmine/block/BlockFactory.php
View File

@ -58,10 +58,10 @@ class BlockFactory{
public static function init() : void{ public static function init() : void{
self::$fullList = new \SplFixedArray(4096); self::$fullList = new \SplFixedArray(4096);
self::$lightFilter = new \SplFixedArray(256); self::$lightFilter = \SplFixedArray::fromArray(array_fill(0, 256, 1));
self::$solid = new \SplFixedArray(256); self::$solid = \SplFixedArray::fromArray(array_fill(0, 256, false));
self::$diffusesSkyLight = new \SplFixedArray(256); self::$diffusesSkyLight = \SplFixedArray::fromArray(array_fill(0, 256, false));
self::$blastResistance = new \SplFixedArray(256); self::$blastResistance = \SplFixedArray::fromArray(array_fill(0, 256, 0));
self::registerBlock(new Air()); self::registerBlock(new Air());
self::registerBlock(new Stone()); self::registerBlock(new Stone());
@ -313,12 +313,6 @@ class BlockFactory{
//TODO: STRUCTURE_BLOCK //TODO: STRUCTURE_BLOCK
//TODO: RESERVED6 //TODO: RESERVED6
for($id = 0, $size = self::$fullList->getSize() >> 4; $id < $size; ++$id){
if(self::$fullList[$id << 4] === null){
self::registerBlock(new UnknownBlock($id));
}
}
} }
/** /**
@ -368,7 +362,7 @@ class BlockFactory{
} }
try{ try{
if(self::$fullList !== null){ if(self::$fullList[($id << 4) | $meta] !== null){
$block = clone self::$fullList[($id << 4) | $meta]; $block = clone self::$fullList[($id << 4) | $meta];
}else{ }else{
$block = new UnknownBlock($id, $meta); $block = new UnknownBlock($id, $meta);