mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-14 01:39:52 +00:00
Code Issues Projects Releases Wiki Activity

Block: make getAllSides() and getHorizontalSides() use underlying Vector3 generators

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-06-29 22:13:07 +01:00
parent 8673a4872e
commit da3f0752a6
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/block/Block.php
View File

@ -492,10 +492,10 @@ class Block{
* @phpstan-return \Generator<int, Block, void, void> * @phpstan-return \Generator<int, Block, void, void>
*/ */
public function getHorizontalSides() : \Generator{ public function getHorizontalSides() : \Generator{
yield $this->getSide(Facing::NORTH); $world = $this->pos->getWorld();
yield $this->getSide(Facing::SOUTH); foreach($this->pos->sidesAroundAxis(Facing::AXIS_Y) as $vector3){
yield $this->getSide(Facing::WEST); yield $world->getBlock($vector3);
yield $this->getSide(Facing::EAST); }
} }
/** /**
@ -505,9 +505,10 @@ class Block{
* @phpstan-return \Generator<int, Block, void, void> * @phpstan-return \Generator<int, Block, void, void>
*/ */
public function getAllSides() : \Generator{ public function getAllSides() : \Generator{
yield $this->getSide(Facing::DOWN); $world = $this->pos->getWorld();
yield $this->getSide(Facing::UP); foreach($this->pos->sides() as $vector3){
yield from $this->getHorizontalSides(); yield $world->getBlock($vector3);
}
} }
/** /**