mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-06 20:07:09 +00:00
Code Issues Projects Releases Wiki Activity

tools/generate-item-upgrade-schema: filter old IDs that were already renamed by previous schemas

Browse Source 
this caused weird outputs if an item was renamed multiple times.
This commit is contained in:
Dylan K. Taylor 2024-01-22 18:48:32 +00:00
parent e77cd39316
commit d97c8e2fd2
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/generate-item-upgrade-schema.php
View File

@ -94,9 +94,14 @@ foreach($files as $file){
$newDiff = []; $newDiff = [];
foreach($target["simple"] as $oldId => $newId){ foreach($target["simple"] as $oldId => $newId){
if(($merged["simple"][$oldId] ?? null) !== $newId){ $previousNewId = $merged["simple"][$oldId] ?? null;
$newDiff["renamedIds"][$oldId] = $newId; if(
$previousNewId === $newId || //if previous schemas already accounted for this
($previousNewId !== null && isset($target["simple"][$previousNewId])) //or the item's ID has been changed for a second time
){
continue;
} }
$newDiff["renamedIds"][$oldId] = $newId;
} }
if(isset($newDiff["renamedIds"])){ if(isset($newDiff["renamedIds"])){
ksort($newDiff["renamedIds"], SORT_STRING); ksort($newDiff["renamedIds"], SORT_STRING);