Typehints on missed sound and particle APIs

src/pocketmine/level/particle/CriticalParticle.php

@@ -26,7 +26,7 @@ namespace pocketmine\level\particle;
 use pocketmine\math\Vector3;
 
 class CriticalParticle extends GenericParticle{
-	public function __construct(Vector3 $pos, $scale = 2){
+	public function __construct(Vector3 $pos, int $scale = 2){
 		parent::__construct($pos, Particle::TYPE_CRITICAL, $scale);
 	}
 }

src/pocketmine/level/particle/DustParticle.php

@@ -26,7 +26,7 @@ namespace pocketmine\level\particle;
 use pocketmine\math\Vector3;
 
 class DustParticle extends GenericParticle{
-	public function __construct(Vector3 $pos, $r, $g, $b, $a = 255){
+	public function __construct(Vector3 $pos, int $r, int $g, int $b, int $a = 255){
 		parent::__construct($pos, Particle::TYPE_DUST, (($a & 0xff) << 24) | (($r & 0xff) << 16) | (($g & 0xff) << 8) | ($b & 0xff));
 	}
 }

src/pocketmine/level/particle/FloatingTextParticle.php

@@ -72,7 +72,7 @@ class FloatingTextParticle extends Particle{
 		return $this->invisible;
 	}
 
-	public function setInvisible(bool $value = true){
+	public function setInvisible(bool $value = true) : void{
 		$this->invisible = $value;
 	}
 

src/pocketmine/level/particle/GenericParticle.php

@@ -27,11 +27,12 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GenericParticle extends Particle{
-
+	/** @var int */
 	protected $id;
+	/** @var int */
 	protected $data;
 
-	public function __construct(Vector3 $pos, $id, $data = 0){
+	public function __construct(Vector3 $pos, int $id, int $data = 0){
 		parent::__construct($pos->x, $pos->y, $pos->z);
 		$this->id = $id & 0xFFF;
 		$this->data = $data;

src/pocketmine/level/particle/HeartParticle.php

@@ -26,7 +26,7 @@ namespace pocketmine\level\particle;
 use pocketmine\math\Vector3;
 
 class HeartParticle extends GenericParticle{
-	public function __construct(Vector3 $pos, $scale = 0){
+	public function __construct(Vector3 $pos, int $scale = 0){
 		parent::__construct($pos, Particle::TYPE_HEART, $scale);
 	}
 }

src/pocketmine/level/particle/InkParticle.php

@@ -26,7 +26,7 @@ namespace pocketmine\level\particle;
 use pocketmine\math\Vector3;
 
 class InkParticle extends GenericParticle{
-	public function __construct(Vector3 $pos, $scale = 0){
+	public function __construct(Vector3 $pos, int $scale = 0){
 		parent::__construct($pos, Particle::TYPE_INK, $scale);
 	}
 }

src/pocketmine/level/particle/MobSpawnParticle.php

@@ -27,11 +27,12 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class MobSpawnParticle extends Particle{
-
+	/** @var int */
 	protected $width;
+	/** @var int */
 	protected $height;
 
-	public function __construct(Vector3 $pos, $width = 0, $height = 0){
+	public function __construct(Vector3 $pos, int $width = 0, int $height = 0){
 		parent::__construct($pos->x, $pos->y, $pos->z);
 		$this->width = $width;
 		$this->height = $height;

src/pocketmine/level/particle/RedstoneParticle.php

@@ -26,7 +26,7 @@ namespace pocketmine\level\particle;
 use pocketmine\math\Vector3;
 
 class RedstoneParticle extends GenericParticle{
-	public function __construct(Vector3 $pos, $lifetime = 1){
+	public function __construct(Vector3 $pos, int $lifetime = 1){
 		parent::__construct($pos, Particle::TYPE_REDSTONE, $lifetime);
 	}
 }

src/pocketmine/level/particle/SmokeParticle.php

@@ -26,7 +26,7 @@ namespace pocketmine\level\particle;
 use pocketmine\math\Vector3;
 
 class SmokeParticle extends GenericParticle{
-	public function __construct(Vector3 $pos, $scale = 0){
+	public function __construct(Vector3 $pos, int $scale = 0){
-		parent::__construct($pos, Particle::TYPE_SMOKE, (int) $scale);
+		parent::__construct($pos, Particle::TYPE_SMOKE, $scale);
 	}
 }

src/pocketmine/level/sound/AnvilBreakSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class AnvilBreakSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ANVIL_BREAK, $pitch);
 	}
 }

src/pocketmine/level/sound/AnvilFallSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class AnvilFallSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ANVIL_FALL, $pitch);
 	}
 }

src/pocketmine/level/sound/AnvilUseSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class AnvilUseSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ANVIL_USE, $pitch);
 	}
 }

src/pocketmine/level/sound/BlazeShootSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class BlazeShootSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_BLAZE_SHOOT, $pitch);
 	}
 }

src/pocketmine/level/sound/ClickSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class ClickSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_CLICK, $pitch);
 	}
 }

src/pocketmine/level/sound/DoorBumpSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class DoorBumpSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_DOOR_BUMP, $pitch);
 	}
 }

src/pocketmine/level/sound/DoorCrashSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class DoorCrashSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_DOOR_CRASH, $pitch);
 	}
 }

src/pocketmine/level/sound/DoorSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class DoorSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_DOOR, $pitch);
 	}
 }

src/pocketmine/level/sound/FizzSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class FizzSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_FIZZ, $pitch);
 	}
 }

src/pocketmine/level/sound/GenericSound.php

@@ -28,24 +28,25 @@ use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GenericSound extends Sound{
 
-	public function __construct(Vector3 $pos, $id, $pitch = 0){
+	/** @var int */
+	protected $id;
+	/** @var float */
+	protected $pitch = 0;
+
+	public function __construct(Vector3 $pos, int $id, float $pitch = 0){
 		parent::__construct($pos->x, $pos->y, $pos->z);
-		$this->id = (int) $id;
+		$this->id = $id;
-		$this->pitch = (float) $pitch * 1000;
+		$this->pitch = $pitch * 1000;
 	}
 
-	protected $pitch = 0;
+	public function getPitch() : float{
-	protected $id;
-
-	public function getPitch(){
 		return $this->pitch / 1000;
 	}
 
-	public function setPitch($pitch){
+	public function setPitch(float $pitch) : void{
-		$this->pitch = (float) $pitch * 1000;
+		$this->pitch = $pitch * 1000;
 	}
 
-
 	public function encode(){
 		$pk = new LevelEventPacket;
 		$pk->evid = $this->id;

src/pocketmine/level/sound/GhastShootSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GhastShootSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_GHAST_SHOOT, $pitch);
 	}
 }

src/pocketmine/level/sound/GhastSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GhastSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_GHAST, $pitch);
 	}
 }

src/pocketmine/level/sound/LaunchSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class LaunchSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_SHOOT, $pitch);
 	}
 }

src/pocketmine/level/sound/PopSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class PopSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_POP, $pitch);
 	}
 }