Typehints on missed sound and particle APIs

src/pocketmine/level/sound/AnvilBreakSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class AnvilBreakSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ANVIL_BREAK, $pitch);
 	}
 }

src/pocketmine/level/sound/AnvilFallSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class AnvilFallSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ANVIL_FALL, $pitch);
 	}
 }

src/pocketmine/level/sound/AnvilUseSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class AnvilUseSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ANVIL_USE, $pitch);
 	}
 }

src/pocketmine/level/sound/BlazeShootSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class BlazeShootSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_BLAZE_SHOOT, $pitch);
 	}
 }

src/pocketmine/level/sound/ClickSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class ClickSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_CLICK, $pitch);
 	}
 }

src/pocketmine/level/sound/DoorBumpSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class DoorBumpSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_DOOR_BUMP, $pitch);
 	}
 }

src/pocketmine/level/sound/DoorCrashSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class DoorCrashSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_DOOR_CRASH, $pitch);
 	}
 }

src/pocketmine/level/sound/DoorSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class DoorSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_DOOR, $pitch);
 	}
 }

src/pocketmine/level/sound/FizzSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class FizzSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_FIZZ, $pitch);
 	}
 }

src/pocketmine/level/sound/GenericSound.php

@@ -28,24 +28,25 @@ use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GenericSound extends Sound{
 
-	public function __construct(Vector3 $pos, $id, $pitch = 0){
+	/** @var int */
+	protected $id;
+	/** @var float */
+	protected $pitch = 0;
+
+	public function __construct(Vector3 $pos, int $id, float $pitch = 0){
 		parent::__construct($pos->x, $pos->y, $pos->z);
-		$this->id = (int) $id;
-		$this->pitch = (float) $pitch * 1000;
+		$this->id = $id;
+		$this->pitch = $pitch * 1000;
 	}
 
-	protected $pitch = 0;
-	protected $id;
-
-	public function getPitch(){
+	public function getPitch() : float{
 		return $this->pitch / 1000;
 	}
 
-	public function setPitch($pitch){
-		$this->pitch = (float) $pitch * 1000;
+	public function setPitch(float $pitch) : void{
+		$this->pitch = $pitch * 1000;
 	}
 
-
 	public function encode(){
 		$pk = new LevelEventPacket;
 		$pk->evid = $this->id;

src/pocketmine/level/sound/GhastShootSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GhastShootSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_GHAST_SHOOT, $pitch);
 	}
 }

src/pocketmine/level/sound/GhastSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class GhastSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_GHAST, $pitch);
 	}
 }

src/pocketmine/level/sound/LaunchSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class LaunchSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_SHOOT, $pitch);
 	}
 }

src/pocketmine/level/sound/PopSound.php

@@ -27,7 +27,7 @@ use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\LevelEventPacket;
 
 class PopSound extends GenericSound{
-	public function __construct(Vector3 $pos, $pitch = 0){
+	public function __construct(Vector3 $pos, float $pitch = 0){
 		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_POP, $pitch);
 	}
 }