mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-17 04:06:54 +00:00
Code Issues Projects Releases Wiki Activity

Item: allow describing type data to a reader as well as a writer

Browse Source 
we don't currently need this, but it's better to have it in case we need it after PM5 release.

This is also now consistent with blocks.
This commit is contained in:
Dylan K. Taylor
2022-08-27 19:18:30 +01:00
parent 5c5d96d00b
commit d5762d3f44
8 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/item/Item.php
View File

@@ -32,6 +32,7 @@ use pocketmine\block\BlockToolType;
use pocketmine\block\VanillaBlocks;
use pocketmine\data\bedrock\EnchantmentIdMap;
use pocketmine\data\bedrock\item\ItemTypeDeserializeException;
use pocketmine\data\runtime\RuntimeDataReader;
use pocketmine\data\runtime\RuntimeDataWriter;
use pocketmine\data\SavedDataLoadingException;
use pocketmine\entity\Entity;
@@ -435,11 +436,11 @@ class Item implements \JsonSerializable{
final public function computeTypeData() : int{
$writer = new RuntimeDataWriter(16); //TODO: max bits should be a constant instead of being hardcoded all over the place
$this->encodeType($writer);
$this->describeType($writer);
return $writer->getValue();
}
protected function encodeType(RuntimeDataWriter $w) : void{
protected function describeType(RuntimeDataReader|RuntimeDataWriter $w) : void{
//NOOP
}