mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 02:08:21 +00:00
Code Issues Projects Releases Wiki Activity

Revert back to separated floor/wall sign

Browse Source 
the conditionally useless properties are problematic.
This commit is contained in:
Dylan K. Taylor
2020-10-04 17:52:23 +01:00
parent e6bf7278fc
commit d3a3a41d2b
29 changed files with 232 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/event/block/SignChangeEvent.php
View File

@ -23,7 +23,7 @@ declare(strict_types=1);
namespace pocketmine\event\block;
use pocketmine\block\Sign;
use pocketmine\block\BaseSign;
use pocketmine\block\utils\SignText;
use pocketmine\event\Cancellable;
use pocketmine\event\CancellableTrait;
@ -35,7 +35,7 @@ use pocketmine\player\Player;
class SignChangeEvent extends BlockEvent implements Cancellable{
use CancellableTrait;
/** @var Sign */
/** @var BaseSign */
private $sign;
/** @var Player */
@ -44,14 +44,14 @@ class SignChangeEvent extends BlockEvent implements Cancellable{
/** @var SignText */
private $text;
public function __construct(Sign $sign, Player $player, SignText $text){
public function __construct(BaseSign $sign, Player $player, SignText $text){
parent::__construct($sign);
$this->sign = $sign;
$this->player = $player;
$this->text = $text;
}
public function getSign() : Sign{
public function getSign() : BaseSign{
return $this->sign;
}