mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-06 01:51:51 +00:00
Code Issues Projects Releases Wiki Activity

InventoryTransaction: Avoid crashing when trying to compact slot changes with invalid slot numbers

Browse Source 
fixes #2250
This commit is contained in:
Dylan K. Taylor 2018-06-19 18:31:13 +01:00
parent 03510333dc
commit d2a037de71
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/pocketmine/inventory/transaction/InventoryTransaction.php
View File

@ -173,6 +173,9 @@ class InventoryTransaction{
$inventory = $inventories[$hash]; $inventory = $inventories[$hash];
$slot = $slots[$hash]; $slot = $slots[$hash];
if(!$inventory->slotExists($slot)){ //this can get hit for crafting tables because the validation happens after this compaction
throw new TransactionValidationException("Slot $slot does not exist in inventory " . get_class($inventory));
}
$sourceItem = $inventory->getItem($slot); $sourceItem = $inventory->getItem($slot);
$targetItem = $this->findResultItem($sourceItem, $list); $targetItem = $this->findResultItem($sourceItem, $list);