mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-17 08:54:22 +00:00
Code Issues Projects Releases Wiki Activity

Add a TODO in BlockStateUpgrader

Browse Source 
this issue can be worked around by adding a dummy schema, but it's a bit clunky.
This commit is contained in:
Dylan K. Taylor 2024-08-05 22:38:32 +01:00
parent be2437ac6e
commit d0d7a995fb
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/data/bedrock/block/upgrade/BlockStateUpgrader.php
View File

@ -83,6 +83,8 @@ final class BlockStateUpgrader{
* version doesn't tell us which of the schemas have already been applied. * version doesn't tell us which of the schemas have already been applied.
* If there's only one schema for a version (the norm), we can safely assume it's already been applied if * If there's only one schema for a version (the norm), we can safely assume it's already been applied if
* the version is the same, and skip over it. * the version is the same, and skip over it.
* TODO: this causes issues when testing isolated schemas since there will only be one schema for a version.
* The second check should be disabled for that case.
*/ */
if($version > $resultVersion || (count($schemaList) === 1 && $version === $resultVersion)){ if($version > $resultVersion || (count($schemaList) === 1 && $version === $resultVersion)){
continue; continue;