mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-04 09:10:00 +00:00
Code Issues Projects Releases Wiki Activity

StupidJsonDecodeTest: use getClosure() instead of traditional mess

Browse Source 
this is faster and requires less code.
This commit is contained in:
Dylan K. Taylor 2019-09-26 11:12:43 +01:00
parent 7a2a4e2aa3
commit d0d61597c7
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/phpunit/network/mcpe/StupidJsonDecodeTest.php
View File

@ -26,6 +26,12 @@ namespace pocketmine\network\mcpe;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
class StupidJsonDecodeTest extends TestCase{ class StupidJsonDecodeTest extends TestCase{
/** @var \Closure */
private $stupidJsonDecodeFunc;
public function setUp() : void{
$this->stupidJsonDecodeFunc = (new \ReflectionMethod(PlayerNetworkSessionAdapter::class, 'stupid_json_decode'))->getClosure();
}
public function stupidJsonDecodeProvider() : array{ public function stupidJsonDecodeProvider() : array{
return [ return [
@ -48,10 +54,7 @@ class StupidJsonDecodeTest extends TestCase{
* @throws \ReflectionException * @throws \ReflectionException
*/ */
public function testStupidJsonDecode(string $brokenJson, $expect){ public function testStupidJsonDecode(string $brokenJson, $expect){
$func = new \ReflectionMethod(PlayerNetworkSessionAdapter::class, 'stupid_json_decode'); $decoded = ($this->stupidJsonDecodeFunc)($brokenJson, true);
$func->setAccessible(true);
$decoded = $func->invoke(null, $brokenJson, true);
self::assertEquals($expect, $decoded); self::assertEquals($expect, $decoded);
} }
} }