mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-15 02:09:42 +00:00
Code Issues Projects Releases Wiki Activity

Remove /reload (#2823)

Browse Source 
For many years, this has been the cause of many users (particularly plugin devs) confusion. The reality is that /reload has little to no practical value. It does not reload plugin source code (contrary to popular belief).
This commit is contained in:
Dylan T 2019-03-22 15:01:11 +00:00 committed by GitHub
parent 6ec2a69417
commit d03f0aab37
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 93 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/pocketmine/Server.php
View File

@ -1570,43 +1570,6 @@ class Server{
return false; return false;
} }
public function reload() : void{
$this->logger->info("Saving worlds...");
foreach($this->levelManager->getLevels() as $level){
$level->save();
}
$this->pluginManager->disablePlugins();
$this->pluginManager->clearPlugins();
PermissionManager::getInstance()->clearPermissions();
$this->commandMap->clearCommands();
$this->logger->info("Reloading properties...");
$this->properties->reload();
$this->maxPlayers = $this->getConfigInt("max-players", 20);
if($this->getConfigBool("hardcore", false) and $this->getDifficulty() < Level::DIFFICULTY_HARD){
$this->setConfigInt("difficulty", Level::DIFFICULTY_HARD);
}
$this->banByIP->load();
$this->banByName->load();
$this->reloadWhitelist();
$this->operators->reload();
foreach($this->getIPBans()->getEntries() as $entry){
$this->getNetwork()->blockAddress($entry->getName(), -1);
}
$this->pluginManager->registerInterface(new PharPluginLoader($this->autoloader));
$this->pluginManager->registerInterface(new ScriptPluginLoader());
$this->pluginManager->loadPlugins($this->pluginPath);
$this->enablePlugins(PluginLoadOrder::STARTUP);
$this->enablePlugins(PluginLoadOrder::POSTWORLD);
TimingsHandler::reload();
}
/** /**
* Shuts the server down correctly * Shuts the server down correctly
*/ */

2
src/pocketmine/command/SimpleCommandMap.php
View File

@ -45,7 +45,6 @@ use pocketmine\command\defaults\PardonCommand;
use pocketmine\command\defaults\PardonIpCommand; use pocketmine\command\defaults\PardonIpCommand;
use pocketmine\command\defaults\ParticleCommand; use pocketmine\command\defaults\ParticleCommand;
use pocketmine\command\defaults\PluginsCommand; use pocketmine\command\defaults\PluginsCommand;
use pocketmine\command\defaults\ReloadCommand;
use pocketmine\command\defaults\SaveCommand; use pocketmine\command\defaults\SaveCommand;
use pocketmine\command\defaults\SaveOffCommand; use pocketmine\command\defaults\SaveOffCommand;
use pocketmine\command\defaults\SaveOnCommand; use pocketmine\command\defaults\SaveOnCommand;
@ -116,7 +115,6 @@ class SimpleCommandMap implements CommandMap{
new PardonIpCommand("pardon-ip"), new PardonIpCommand("pardon-ip"),
new ParticleCommand("particle"), new ParticleCommand("particle"),
new PluginsCommand("plugins"), new PluginsCommand("plugins"),
new ReloadCommand("reload"),
new SaveCommand("save-all"), new SaveCommand("save-all"),
new SaveOffCommand("save-off"), new SaveOffCommand("save-off"),
new SaveOnCommand("save-on"), new SaveOnCommand("save-on"),

54
src/pocketmine/command/defaults/ReloadCommand.php
View File

@ -1,54 +0,0 @@
<?php
/*
*
* ____ _ _ __ __ _ __ __ ____
* | _ \ ___ ___| | _____| |_| \/ (_)_ __ ___ | \/ | _ \
* | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
* | __/ (_) | (__| < __/ |_| | | | | | | | __/_____| | | | __/
* |_| \___/ \___|_|\_\___|\__|_| |_|_|_| |_|\___| |_| |_|_|
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* @author PocketMine Team
* @link http://www.pocketmine.net/
*
*
*/
declare(strict_types=1);
namespace pocketmine\command\defaults;
use pocketmine\command\Command;
use pocketmine\command\CommandSender;
use pocketmine\lang\TranslationContainer;
use pocketmine\utils\TextFormat;
class ReloadCommand extends VanillaCommand{
public function __construct(string $name){
parent::__construct(
$name,
"%pocketmine.command.reload.description",
"%pocketmine.command.reload.usage"
);
$this->setPermission("pocketmine.command.reload");
}
public function execute(CommandSender $sender, string $commandLabel, array $args){
if(!$this->testPermission($sender)){
return true;
}
Command::broadcastCommandMessage($sender, new TranslationContainer(TextFormat::YELLOW . "%pocketmine.command.reload.reloading"));
$sender->getServer()->reload();
Command::broadcastCommandMessage($sender, new TranslationContainer(TextFormat::YELLOW . "%pocketmine.command.reload.reloaded"));
return true;
}
}