mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-13 09:19:42 +00:00
Code Issues Projects Releases Wiki Activity

Player: remove iusername premature optimization

Browse Source
This commit is contained in:
Dylan K. Taylor 2019-07-05 17:28:37 +01:00
parent 45b0cbc796
commit ceeed57118
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/Server.php
View File

@ -674,7 +674,7 @@ class Server{
public function getPlayerExact(string $name) : ?Player{ public function getPlayerExact(string $name) : ?Player{
$name = strtolower($name); $name = strtolower($name);
foreach($this->getOnlinePlayers() as $player){ foreach($this->getOnlinePlayers() as $player){
if($player->getLowerCaseName() === $name){ if(strtolower($player->getName()) === $name){
return $player; return $player;
} }
} }
@ -694,7 +694,7 @@ class Server{
$partialName = strtolower($partialName); $partialName = strtolower($partialName);
$matchedPlayers = []; $matchedPlayers = [];
foreach($this->getOnlinePlayers() as $player){ foreach($this->getOnlinePlayers() as $player){
if($player->getLowerCaseName() === $partialName){ if(strtolower($player->getName()) === $partialName){
$matchedPlayers = [$player]; $matchedPlayers = [$player];
break; break;
}elseif(stripos($player->getName(), $partialName) !== false){ }elseif(stripos($player->getName(), $partialName) !== false){

10
src/pocketmine/player/Player.php
View File

@ -165,8 +165,6 @@ class Player extends Human implements CommandSender, ChunkLoader, ChunkListener,
/** @var string */ /** @var string */
protected $username; protected $username;
/** @var string */ /** @var string */
protected $iusername;
/** @var string */
protected $displayName; protected $displayName;
/** @var int */ /** @var int */
protected $randomClientId; protected $randomClientId;
@ -277,7 +275,6 @@ class Player extends Human implements CommandSender, ChunkLoader, ChunkListener,
$this->username = $username; $this->username = $username;
$this->displayName = $this->username; $this->displayName = $this->username;
$this->iusername = strtolower($this->username);
$this->locale = $this->playerInfo->getLocale(); $this->locale = $this->playerInfo->getLocale();
$this->randomClientId = $this->playerInfo->getClientId(); $this->randomClientId = $this->playerInfo->getClientId();
@ -706,13 +703,6 @@ class Player extends Human implements CommandSender, ChunkLoader, ChunkListener,
return $this->username; return $this->username;
} }
/**
* @return string
*/
public function getLowerCaseName() : string{
return $this->iusername;
}
/** /**
* Gets the "friendly" name to display of this player to use in the chat. * Gets the "friendly" name to display of this player to use in the chat.
* *