mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-25 20:33:59 +00:00
Code Issues Projects Releases Wiki Activity

Utils: be explicit about class existence checking in testValidInstance()

Browse Source
This commit is contained in:
Dylan K. Taylor 2021-08-21 15:57:57 +01:00
parent 4d73c93886
commit cd9af7f9f6
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/utils/Utils.php
View File

@ -36,6 +36,7 @@ use function array_reverse;
use function array_values; use function array_values;
use function bin2hex; use function bin2hex;
use function chunk_split; use function chunk_split;
use function class_exists;
use function count; use function count;
use function debug_zval_dump; use function debug_zval_dump;
use function dechex; use function dechex;
@ -466,17 +467,14 @@ final class Utils{
* @phpstan-param class-string $baseName * @phpstan-param class-string $baseName
*/ */
public static function testValidInstance(string $className, string $baseName) : void{ public static function testValidInstance(string $className, string $baseName) : void{
try{ if(!class_exists($baseName)){
$base = new \ReflectionClass($baseName);
}catch(\ReflectionException $e){
throw new \InvalidArgumentException("Base class $baseName does not exist"); throw new \InvalidArgumentException("Base class $baseName does not exist");
} }
if(!class_exists($className)){
try{
$class = new \ReflectionClass($className);
}catch(\ReflectionException $e){
throw new \InvalidArgumentException("Class $className does not exist"); throw new \InvalidArgumentException("Class $className does not exist");
} }
$base = new \ReflectionClass($baseName);
$class = new \ReflectionClass($className);
if(!$class->isSubclassOf($baseName)){ if(!$class->isSubclassOf($baseName)){
throw new \InvalidArgumentException("Class $className does not " . ($base->isInterface() ? "implement" : "extend") . " " . $baseName); throw new \InvalidArgumentException("Class $className does not " . ($base->isInterface() ? "implement" : "extend") . " " . $baseName);