Merge remote-tracking branch 'PocketMine/mcpe-0.12' into Stonecutter-Recipes

src/pocketmine/Player.php

@@ -263,7 +263,7 @@ class Player extends Human implements CommandSender, InventoryHolder, ChunkLoade
 	}
 
 	public function getClientSecret(){
-		return $this->clientSecretId;
+		return $this->clientSecret;
 	}
 
 	public function isBanned(){
@@ -1691,7 +1691,7 @@ class Player extends Human implements CommandSender, InventoryHolder, ChunkLoade
 		if($this->isCreative()){
 			$this->inventory->setHeldItemSlot(0);
 		}else{
-			$this->inventory->setHeldItemSlot(0);
+			$this->inventory->setHeldItemSlot($this->inventory->getHotbarSlotIndex(0));
 		}
 
 		$pk = new PlayStatusPacket();
@@ -1706,6 +1706,7 @@ class Player extends Human implements CommandSender, InventoryHolder, ChunkLoade
 
 		$pk = new StartGamePacket();
 		$pk->seed = -1;
+		$pk->dimension = 0;
 		$pk->x = $this->x;
 		$pk->y = $this->y;
 		$pk->z = $this->z;
@@ -1809,7 +1810,7 @@ class Player extends Human implements CommandSender, InventoryHolder, ChunkLoade
 				$this->setNameTag($this->username);
 				$this->iusername = strtolower($this->username);
 
-				if(count($this->server->getOnlinePlayers()) > $this->server->getMaxPlayers() and $this->kick("disconnectionScreen.serverFull", false)){
+				if(count($this->server->getOnlinePlayers()) >= $this->server->getMaxPlayers() and $this->kick("disconnectionScreen.serverFull", false)){
 					break;
 				}
 

src/pocketmine/event/Cancellable.php

@@ -28,5 +28,5 @@ namespace pocketmine\event;
 interface Cancellable{
 	public function isCancelled();
 
-	public function setCancelled($forceCancel = false);
+	public function setCancelled($value = true);
 }

src/pocketmine/inventory/PlayerInventory.php

@@ -383,11 +383,18 @@ class PlayerInventory extends BaseInventory{
 		}
 
 		$pk = new ContainerSetContentPacket();
-		$pk;
 		$pk->slots = [];
+		$holder = $this->getHolder();
+		if($holder instanceof Player and $holder->isCreative()){
+			//TODO: Remove this workaround because of broken client
+			foreach(Item::getCreativeItems() as $i => $item){
+				$pk->slots[$i] = Item::getCreativeItem($i);
+			}
+		}else{
 			for($i = 0; $i < $this->getSize(); ++$i){ //Do not send armor by error here
 				$pk->slots[$i] = $this->getItem($i);
 			}
+		}
 
 		foreach($target as $player){
 			$pk->hotbar = [];
@@ -416,7 +423,6 @@ class PlayerInventory extends BaseInventory{
 		}
 
 		$pk = new ContainerSetSlotPacket();
-		$pk;
 		$pk->slot = $index;
 		$pk->item = clone $this->getItem($index);
 

src/pocketmine/level/Level.php

@@ -872,7 +872,7 @@ class Level implements ChunkManager, Metadatable{
 			}
 
 			if(count($this->blockCache) > 2048){
-				$this->chunkCache = [];
+				$this->blockCache = [];
 			}
 
 		}
@@ -2340,7 +2340,7 @@ class Level implements ChunkManager, Metadatable{
 		$this->server->getPluginManager()->callEvent(new SpawnChangeEvent($this, $previousSpawn));
 	}
 
-	public function requestChunk($x, $z, Player $player, $order = LevelProvider::ORDER_ZXY){
+	public function requestChunk($x, $z, Player $player){
 		$index = Level::chunkHash($x, $z);
 		if(!isset($this->chunkSendQueue[$index])){
 			$this->chunkSendQueue[$index] = [];

src/pocketmine/level/sound/EndermanTeleportSound.php

@@ -0,0 +1,31 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+namespace pocketmine\level\sound;
+
+use pocketmine\math\Vector3;
+use pocketmine\network\protocol\LevelEventPacket;
+
+class EndermanTeleportSound extends GenericSound{
+	public function __construct(Vector3 $pos){
+		parent::__construct($pos, LevelEventPacket::EVENT_SOUND_ENDERMAN_TELEPORT);
+	}
+}

src/pocketmine/network/protocol/LevelEventPacket.php

@@ -43,6 +43,7 @@ class LevelEventPacket extends DataPacket{
 	const EVENT_SOUND_BAT_FLY = 1015;
 	const EVENT_SOUND_ZOMBIE_INFECT = 1016;
 	const EVENT_SOUND_ZOMBIE_HEAL = 1017;
+	const EVENT_SOUND_ENDERMAN_TELEPORT = 1018;
 
 	const EVENT_SOUND_ANVIL_BREAK = 1020;
 	const EVENT_SOUND_ANVIL_USE = 1021;

src/pocketmine/scheduler/SendUsageTask.php

@@ -25,6 +25,7 @@ use pocketmine\network\protocol\Info;
 use pocketmine\Server;
 use pocketmine\utils\Utils;
 use pocketmine\utils\VersionString;
+use pocketmine\utils\UUID;
 
 class SendUsageTask extends AsyncTask{
 
@@ -39,9 +40,9 @@ class SendUsageTask extends AsyncTask{
 		$endpoint = "http://" . $server->getProperty("anonymous-statistics.host", "stats.pocketmine.net") . "/";
 
 		$data = [];
-		$data["uniqueServerId"] = $server->getServerUniqueId();
+		$data["uniqueServerId"] = $server->getServerUniqueId()->toString();
-		$data["uniqueMachineId"] = Utils::getMachineUniqueId();
+		$data["uniqueMachineId"] = Utils::getMachineUniqueId()->toString();
-		$data["uniqueRequestId"] = Utils::dataToUUID($server->getServerUniqueId(), microtime(true));
+		$data["uniqueRequestId"] = UUID::fromData($server->getServerUniqueId(), microtime(true))->toString();
 
 		switch($type){
 			case self::TYPE_OPEN:

src/pocketmine/tile/EnchantTable.php

@@ -29,7 +29,7 @@ class EnchantTable extends Spawnable implements Nameable{
 
 
 	public function getName(){
-		return isset($this->namedtag->CustomName) ? $this->namedtag->CustomName->getValue() : "Chest";
+		return isset($this->namedtag->CustomName) ? $this->namedtag->CustomName->getValue() : "Enchanting Table";
 	}
 
 	public function hasName(){

src/pocketmine/tile/Furnace.php

@@ -71,7 +71,7 @@ class Furnace extends Tile implements InventoryHolder, Container, Nameable{
 	}
 
 	public function getName(){
-		return isset($this->namedtag->CustomName) ? $this->namedtag->CustomName->getValue() : "Chest";
+		return isset($this->namedtag->CustomName) ? $this->namedtag->CustomName->getValue() : "Furnace";
 	}
 
 	public function hasName(){

src/pocketmine/utils/BinaryStream.php

@@ -105,14 +105,22 @@ class BinaryStream extends \stdClass{
 		$this->buffer .= Binary::writeLInt($v);
 	}
 
-	public function getShort($signed = true){
+	public function getSignedShort(){
-		return $signed ? Binary::readSignedShort($this->get(2)) : Binary::readShort($this->get(2));
+		return Binary::readSignedShort($this->get(2));
 	}
 
 	public function putShort($v){
 		$this->buffer .= Binary::writeShort($v);
 	}
 
+	public function getShort(){
+		return Binary::readShort($this->get(2));
+	}
+
+	public function putSignedShort($v){
+		$this->buffer .= Binary::writeShort($v);
+	}
+
 	public function getFloat(){
 		return Binary::readFloat($this->get(4));
 	}
@@ -188,7 +196,7 @@ class BinaryStream extends \stdClass{
 	}
 
 	public function getSlot(){
-		$id = $this->getShort(true);
+		$id = $this->getSignedShort();
 		
 		if($id <= 0){
 			return Item::get(0, 0, 0);

src/pocketmine/utils/ServerKiller.php

@@ -33,7 +33,7 @@ class ServerKiller extends Thread{
 
 	public function run(){
 		sleep($this->time);
-		echo "\nTook to long to stop, server was killed forcefully!\n";
+		echo "\nTook too long to stop, server was killed forcefully!\n";
 		@\pocketmine\kill(getmypid());
 	}