mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

BlockStateData: use array<Tag> instead of CompoundTag to store state properties

Browse Source 
this reduces the footprint of RuntimeBlockMapping by a further 1 MB, as well as simplifying various parts of the code, and solidifying the immutability guarantee of BlockStateData.
This commit is contained in:
Dylan K. Taylor
2022-07-09 16:03:51 +01:00
parent 151f2c3f3a
commit ccb3c3cb05
17 changed files with 148 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/data/bedrock/block/convert/BlockStateWriter.php
View File

@ -35,17 +35,22 @@ use pocketmine\data\bedrock\block\BlockStateSerializeException;
use pocketmine\data\bedrock\block\BlockStateStringValues as StringValues;
use pocketmine\math\Axis;
use pocketmine\math\Facing;
use pocketmine\nbt\tag\CompoundTag;
use pocketmine\nbt\tag\ByteTag;
use pocketmine\nbt\tag\IntTag;
use pocketmine\nbt\tag\StringTag;
use pocketmine\nbt\tag\Tag;
final class BlockStateWriter{
private CompoundTag $states;
/**
* @var Tag[]
* @phpstan-var array<string, Tag>
*/
private array $states = [];
public function __construct(
private string $id
){
$this->states = CompoundTag::create();
}
){}
public static function create(string $id) : self{
return new self($id);
@ -53,19 +58,19 @@ final class BlockStateWriter{
/** @return $this */
public function writeBool(string $name, bool $value) : self{
$this->states->setByte($name, $value ? 1 : 0);
$this->states[$name] = new ByteTag($value ? 1 : 0);
return $this;
}
/** @return $this */
public function writeInt(string $name, int $value) : self{
$this->states->setInt($name, $value);
$this->states[$name] = new IntTag($value);
return $this;
}
/** @return $this */
public function writeString(string $name, string $value) : self{
$this->states->setString($name, $value);
$this->states[$name] = new StringTag($value);
return $this;
}