From cb40484a2ec91e124c41cb05b1dc561ef9fd25e1 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 27 Jul 2019 14:52:53 +0100 Subject: [PATCH] AsyncTask: Remove a bunch of reference-management drivel from documentation of storeLocal() this works (mostly) the same way regular properties do, so the usual rules are implied. --- src/pocketmine/scheduler/AsyncTask.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/pocketmine/scheduler/AsyncTask.php b/src/pocketmine/scheduler/AsyncTask.php index b34cc34f2..d0158eb20 100644 --- a/src/pocketmine/scheduler/AsyncTask.php +++ b/src/pocketmine/scheduler/AsyncTask.php @@ -229,13 +229,6 @@ abstract class AsyncTask extends Collectable{ * Objects stored in this storage MUST be retrieved through {@link AsyncTask::fetchLocal} when {@link AsyncTask::onCompletion} is called. * Otherwise, a NOTICE level message will be raised and the reference will be removed after onCompletion exits. * - * WARNING: Use this method carefully. It might take a long time before an AsyncTask is completed. PocketMine will - * keep a strong reference to objects passed in this method. This may result in a light memory leak. Usually this - * does not cause memory failure, but be aware that the object may be no longer usable when the AsyncTask completes. - * (E.g. a Level object is no longer usable because it is unloaded while the AsyncTask is executing, or even a - * plugin might be unloaded). Since PocketMine keeps a strong reference, the objects are still valid, but the - * implementation is responsible for checking whether these objects are still usable. - * * WARNING: THIS METHOD SHOULD ONLY BE CALLED FROM THE MAIN THREAD! * * @param mixed $complexData the data to store