mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-06 10:01:53 +00:00
Code Issues Projects Releases Wiki Activity

PluginManager: fixed mishandling of self-disabling plugins in enablePlugins()

Browse Source 
this caused a leak of the plugin context, PluginEnableEvent to be called with a disabled plugin, and the plugin's scheduler to get ticked.
This commit is contained in:
Dylan K. Taylor 2022-03-03 18:48:52 +00:00
parent 3e90c3072a
commit c9c50e16ec
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugin/PluginManager.php
View File

@ -435,10 +435,11 @@ class PluginManager{
$plugin->getScheduler()->setEnabled(true); $plugin->getScheduler()->setEnabled(true);
$plugin->onEnableStateChange(true); $plugin->onEnableStateChange(true);
if($plugin->isEnabled()){ //the plugin may have disabled itself during onEnable()
$this->enabledPlugins[$plugin->getDescription()->getName()] = $plugin;
$this->enabledPlugins[$plugin->getDescription()->getName()] = $plugin; (new PluginEnableEvent($plugin))->call();
}
(new PluginEnableEvent($plugin))->call();
} }
} }