mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-16 03:51:37 +00:00
Code Issues Projects Releases Wiki Activity

ItemSerializer: avoid slow NBT check

Browse Source 
hasNamedTag() rebuilds the NBT from item properties to decide if there's any NBT.
This is a waste of resources when we then fetch the tag to encode anyway.
This commit is contained in:
Dylan K. Taylor
2025-09-10 20:06:35 +01:00
parent 54e8ad2a9c
commit c854f2c765
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/data/bedrock/item/ItemSerializer.php
View File

@@ -117,8 +117,8 @@ final class ItemSerializer{
$data = $serializer($item); $data = $serializer($item);
} }
if($item->hasNamedTag()){ $resultTag = $item->getNamedTag();
$resultTag = $item->getNamedTag(); if($resultTag->count() > 0){
$extraTag = $data->getTag(); $extraTag = $data->getTag();
if($extraTag !== null){ if($extraTag !== null){
$resultTag = $resultTag->merge($extraTag); $resultTag = $resultTag->merge($extraTag);